From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/3] tests/i915/gem_exec_schedule: Don't use default context
Date: Thu, 21 Apr 2022 08:09:54 +0200 [thread overview]
Message-ID: <20220421060955.21016-3-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20220421060955.21016-1-zbigniew.kempczynski@intel.com>
Config created on top of all physical devices may provide more devices
than default context contains. Using engine id from such "richer"
context is wrong when default context will be chosen for this engine.
Add dedicated context to handle all engines covered by context cfg.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/5444 (timeslicing)
---
tests/i915/gem_exec_schedule.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
index caeac255de..dfcff849c8 100644
--- a/tests/i915/gem_exec_schedule.c
+++ b/tests/i915/gem_exec_schedule.c
@@ -568,7 +568,7 @@ static void timeslice(int i915, const intel_ctx_cfg_t *cfg,
.buffers_ptr = to_user_pointer(&obj),
.buffer_count = 1,
};
- const intel_ctx_t *ctx;
+ const intel_ctx_t *ctx[2];
uint32_t *result;
int out;
@@ -582,22 +582,25 @@ static void timeslice(int i915, const intel_ctx_cfg_t *cfg,
igt_require(gem_scheduler_has_timeslicing(i915));
igt_require(intel_gen(intel_get_drm_devid(i915)) >= 8);
+ ctx[0] = intel_ctx_create(i915, cfg);
obj.handle = timeslicing_batches(i915, &offset);
result = gem_mmap__device_coherent(i915, obj.handle, 0, 4096, PROT_READ);
execbuf.flags = engine | I915_EXEC_FENCE_OUT;
execbuf.batch_start_offset = 0;
+ execbuf.rsvd1 = ctx[0]->id;
gem_execbuf_wr(i915, &execbuf);
+ intel_ctx_destroy(i915, ctx[0]);
/* No coupling between requests; free to timeslice */
- ctx = intel_ctx_create(i915, cfg);
- execbuf.rsvd1 = ctx->id;
+ ctx[1] = intel_ctx_create(i915, cfg);
+ execbuf.rsvd1 = ctx[1]->id;
execbuf.rsvd2 >>= 32;
execbuf.flags = engine | I915_EXEC_FENCE_OUT;
execbuf.batch_start_offset = offset;
gem_execbuf_wr(i915, &execbuf);
- intel_ctx_destroy(i915, ctx);
+ intel_ctx_destroy(i915, ctx[1]);
gem_sync(i915, obj.handle);
gem_close(i915, obj.handle);
--
2.32.0
next prev parent reply other threads:[~2022-04-21 6:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 6:09 [igt-dev] [PATCH i-g-t 0/3] Fix couple of gem_exec_schedule subtests Zbigniew Kempczyński
2022-04-21 6:09 ` [igt-dev] [PATCH i-g-t 1/3] i915/gem_exec_schedule: Fix context creation for shared-vm Zbigniew Kempczyński
2022-04-21 19:46 ` Kamil Konieczny
2022-04-21 6:09 ` Zbigniew Kempczyński [this message]
2022-04-21 19:51 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915/gem_exec_schedule: Don't use default context Kamil Konieczny
2022-04-22 6:12 ` Zbigniew Kempczyński
2022-04-22 10:27 ` Kamil Konieczny
2022-04-21 6:09 ` [igt-dev] [PATCH i-g-t 3/3] tests/i915/gem_exec_schedule: Use separate context for spinner Zbigniew Kempczyński
2022-04-21 20:00 ` Kamil Konieczny
2022-04-21 6:33 ` [igt-dev] ✗ GitLab.Pipeline: warning for Fix couple of gem_exec_schedule subtests Patchwork
2022-04-21 7:01 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2022-04-21 9:03 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix couple of gem_exec_schedule subtests (rev2) Patchwork
2022-04-21 11:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-04-21 11:13 ` Zbigniew Kempczyński
2022-04-22 10:29 ` Zbigniew Kempczyński
2022-04-25 15:15 ` Vudum, Lakshminarayana
2022-04-25 15:37 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421060955.21016-3-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox