From: Ramalingam C <ramalingam.c@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_lmem_swapping: Add parallel-random-verify-ccs subtest
Date: Thu, 21 Apr 2022 12:26:01 +0530 [thread overview]
Message-ID: <20220421065600.GA18679@intel.com> (raw)
In-Reply-To: <20220421065008.24682-1-zbigniew.kempczynski@intel.com>
On 2022-04-21 at 08:50:08 +0200, Zbigniew Kempczyński wrote:
> For this subtest we need to use allocator thread so parallel subtests
> need to be executed in allocator multi-process aware environment.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Looks good to me. And tested too.
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> ---
> tests/i915/gem_lmem_swapping.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/i915/gem_lmem_swapping.c b/tests/i915/gem_lmem_swapping.c
> index e58a1f505f..5d93e9daae 100644
> --- a/tests/i915/gem_lmem_swapping.c
> +++ b/tests/i915/gem_lmem_swapping.c
> @@ -576,6 +576,7 @@ static void test_evict(int i915,
> if (flags & TEST_PARALLEL) {
> int fd = gem_reopen_driver(i915);
>
> + intel_allocator_multiprocess_start();
> ctx = intel_ctx_create_all_physical(fd);
> __gem_context_set_persistence(fd, ctx->id, false);
>
> @@ -586,6 +587,7 @@ static void test_evict(int i915,
> igt_waitchildren();
> intel_ctx_destroy(fd, ctx);
> close(fd);
> + intel_allocator_multiprocess_stop();
> } else {
> __do_evict(i915, ctx, ®ion->region, ¶ms, params.seed);
> }
> @@ -747,6 +749,7 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
> { "verify-random-ccs", TEST_CCS | TEST_RANDOM },
> { "heavy-verify-random-ccs", TEST_CCS | TEST_RANDOM | TEST_HEAVY },
> { "heavy-verify-multi-ccs", TEST_CCS | TEST_RANDOM | TEST_HEAVY | TEST_ENGINES | TEST_MULTI },
> + { "parallel-random-verify-ccs", TEST_PARALLEL | TEST_RANDOM | TEST_CCS },
> { }
> };
> const intel_ctx_t *ctx;
> --
> 2.32.0
>
next prev parent reply other threads:[~2022-04-21 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 6:50 [igt-dev] [PATCH i-g-t] tests/i915/gem_lmem_swapping: Add parallel-random-verify-ccs subtest Zbigniew Kempczyński
2022-04-21 6:56 ` Ramalingam C [this message]
2022-04-21 7:08 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2022-04-21 7:31 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-04-21 11:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421065600.GA18679@intel.com \
--to=ramalingam.c@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox