Re: [igt-dev] [PATCH i-g-t 2/4] tests/i915/i915_suspend: Be more specific on the S3 mem_sleep requirement.

[Anshuman Gupta <anshuman.gupta@intel.com>]

On 2022-07-13 at 11:52:31 -0400, Rodrigo Vivi wrote:
> 1. We are not using DISK
> 2. DISK has no dependency on mem_sleep.
> 
> Let's be clear on what exactly we are trying to do.
> 
> Cc: Riana Tauro <riana.tauro@intel.com>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  tests/i915/i915_suspend.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c
> index f992d447..222a8e4a 100644
> --- a/tests/i915/i915_suspend.c
> +++ b/tests/i915/i915_suspend.c
> @@ -209,8 +209,9 @@ test_suspend_without_i915(int state)
>  	igt_kmsg(KMSG_INFO "Unloading i915\n");
>  	igt_assert_eq(igt_i915_driver_unload(),0);
>  
> -	igt_skip_on_f(igt_get_memsleep_state() == MEM_SLEEP_S2IDLE && state > SUSPEND_STATE_FREEZE,
> -		      "Platform default mem_sleep state is s2idle\n");
> +	igt_skip_on_f(igt_get_memsleep_state() == MEM_SLEEP_S2IDLE &&
> +		      state == SUSPEND_STATE_MEM,
STANDBY state has the dependency on mem_sleep, so "state > SUSPEND_STATE_FREEZE" should be the correct condition,
but as follow on patch removes above hunk.
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
> +		      "S3 not possible: platform default mem_sleep state is s2idle\n");
>  	igt_system_suspend_autoresume(state, SUSPEND_TEST_NONE);
>  
>  	igt_kmsg(KMSG_INFO "Re-loading i915 \n");
> -- 
> 2.35.3
>