From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC9F5A7280 for ; Mon, 22 Aug 2022 23:57:07 +0000 (UTC) From: Umesh Nerlige Ramappa To: igt-dev@lists.freedesktop.org Date: Mon, 22 Aug 2022 23:56:56 +0000 Message-Id: <20220822235657.280702-23-umesh.nerlige.ramappa@intel.com> In-Reply-To: <20220822235657.280702-1-umesh.nerlige.ramappa@intel.com> References: <20220822235657.280702-1-umesh.nerlige.ramappa@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t 22/23] lib/i915/perf: make warning message more helpful List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Lionel Landwerlin This helped debugging some XEHPSDV stuff but is also more readable. Signed-off-by: Lionel Landwerlin --- lib/i915/perf-configs/mdapi-xml-convert.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/i915/perf-configs/mdapi-xml-convert.py b/lib/i915/perf-configs/mdapi-xml-convert.py index f27d6657..1d161674 100755 --- a/lib/i915/perf-configs/mdapi-xml-convert.py +++ b/lib/i915/perf-configs/mdapi-xml-convert.py @@ -884,10 +884,15 @@ for arg in args.xml: # delta equations are expected to be identical so warn if that's # not true... if bool(raw_read_eq) ^ bool(delta_read_eq) or raw_read_eq != delta_read_eq: - print_err("WARNING: Inconsistent raw and delta report equations for " + \ - mdapi_set.get('ShortName') + " :: " + mdapi_counter.get('SymbolName') + \ - "(" + mdapi_counter.get('ShortName') + ")" + ": raw=\"" + str(raw_read_eq) + \ - "\" delta=\"" + str(delta_read_eq) + "\" (SKIPPING)") + print_err(("WARNING: Inconsistent raw and delta report equations for {0} :: {1} ({2}): " + + "raw=\"{3}\" / \"{4}\" delta=\"{5}\" / \"{6}\" (SKIPPING)") + .format(mdapi_set.get('ShortName'), + mdapi_counter.get('SymbolName'), + mdapi_counter.get('ShortName'), + str(raw_read_eq), + mdapi_counter.get('SnapshotReportReadEquation'), + str(delta_read_eq), + mdapi_counter.get('DeltaReportReadEquation'))) set.remove(counter) continue -- 2.25.1