public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: markyacoub@google.com
Subject: [igt-dev] [PATCH 1/2][V4] tests/kms_universal_plane: Enable gen9_test_pipe for all devices
Date: Sat, 3 Sep 2022 11:48:02 -0600	[thread overview]
Message-ID: <20220903174803.2937836-1-alex.hung@amd.com> (raw)

This subtest runs on non-i915 devices, and let's make it generic by
removing igt_require_intel and renaming it.

Signed-off-by: Alex Hung <alex.hung@amd.com>
Reviewed-by: Mark Yacoub <markyacoub@chromium.org>
---
 tests/kms_universal_plane.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index 3cb6d704..9eab1a57 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -699,15 +699,14 @@ gen9_test_fini(gen9_test_t *test, igt_output_t *output)
  * windowing)
  */
 static void
-gen9_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
+pageflip_win_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 {
 	gen9_test_t test = { .data = data };
 	igt_plane_t *primary;
 
 	int ret = 0;
 
-	igt_require_intel(data->drm_fd);
-	igt_skip_on(data->display_ver < 9);
+	igt_skip_on(is_i915_device(data->drm_fd) && data->display_ver < 9);
 	igt_require_pipe(&data->display, pipe);
 
 	igt_output_set_pipe(output, pipe);
@@ -787,10 +786,10 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
 			cursor_leak_test_pipe(data, pipe, output);
 
 	igt_describe("Check if pageflip succeeds in windowed setting");
-	igt_subtest_f("universal-plane-gen9-features-pipe-%s",
+	igt_subtest_f("universal-plane-pageflip-windowed-pipe-%s",
 		      kmstest_pipe_name(pipe))
 		for_each_valid_output_on_pipe(&data->display, pipe, output)
-			gen9_test_pipe(data, pipe, output);
+			pageflip_win_test_pipe(data, pipe, output);
 }
 
 static data_t data;
-- 
2.34.1

             reply	other threads:[~2022-09-03 17:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-03 17:48 Alex Hung [this message]
2022-09-03 17:48 ` [igt-dev] [PATCH 2/2][V4] tests/kms_universal_plane: Skip offscreen test for universal API Alex Hung
2022-09-06 13:50   ` Mark Yacoub
2022-11-11 10:33   ` Ville Syrjälä
2022-09-03 18:34 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [1/2,V4] tests/kms_universal_plane: Enable gen9_test_pipe for all devices Patchwork
2022-09-03 22:50 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [1/2,V4] tests/kms_universal_plane: Enable gen9_test_pipe for all devices (rev2) Patchwork
2022-09-04  8:06 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-09-04  9:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-05  5:35 ` Patchwork
2022-09-05  6:18 ` Patchwork
2022-09-06  6:14 ` Patchwork
2022-09-06  7:01 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220903174803.2937836-1-alex.hung@amd.com \
    --to=alex.hung@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=markyacoub@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox