public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Arun R Murthy <arun.r.murthy@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jani.nikula@intel.com, petri.latvala@intel.com,
	Arun R Murthy <arun.r.murthy@intel.com>
Subject: [igt-dev] [PATCHv3 i-g-t] tests/kms_async_flips: Enable async flip on linear buffer
Date: Mon,  5 Sep 2022 17:31:50 +0530	[thread overview]
Message-ID: <20220905120150.4074178-1-arun.r.murthy@intel.com> (raw)
In-Reply-To: <20220829093147.3836523-1-arun.r.murthy@intel.com>

On Intel Gen platforms >= GEN12, Async on linear buffer is supported,
hence enabling test for the same.

v2: Added new line character for igt_skip_on_f (Petri)
    Added new element modifier in data struct (JP)
v3: Use display ver instead of graphics ver(Jani N)

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 tests/kms_async_flips.c | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 695aea74..7ff71d83 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -61,6 +61,7 @@ typedef struct {
 	bool extended;
 	enum pipe pipe;
 	bool alternate_sync_async;
+	uint64_t modifier;
 } data_t;
 
 static void flip_handler(int fd_, unsigned int sequence, unsigned int tv_sec,
@@ -125,7 +126,7 @@ static void make_fb(data_t *data, struct igt_fb *fb,
 
 	if (is_i915_device(data->drm_fd)) {
 		igt_create_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
-			      I915_FORMAT_MOD_X_TILED, fb);
+			      data->modifier, fb);
 		igt_draw_fill_fb(data->drm_fd, fb, 0x88);
 	} else {
 		igt_create_color_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
@@ -594,21 +595,37 @@ igt_main_args("e", NULL, help_str, opt_handler, &data)
 		igt_fixture
 			require_monotonic_timestamp(data.drm_fd);
 
-		igt_describe("Wait for page flip events in between successive asynchronous flips");
+		igt_describe("Wait for page flip events in between successive asynchronous flips on X Tiled buffer");
 		igt_subtest_with_dynamic("async-flip-with-page-flip-events") {
 			data.alternate_sync_async = false;
+			data.modifier = I915_FORMAT_MOD_X_TILED;
 			run_test(&data, test_async_flip);
 		}
 
+		igt_describe("Wait for page flip events in between successive asynchronous flips on Linear buffer");
+		igt_subtest_with_dynamic("async-flip-with-page-flip-events-linear") {
+			data.alternate_sync_async = false;
+			data.modifier = DRM_FORMAT_MOD_LINEAR;
+			if(is_i915_device(data.drm_fd)) {
+				igt_skip_on_f(intel_display_ver(
+						intel_get_drm_devid(data.drm_fd)) < 12,
+						"Async on Linear buffer not supported\n");
+				run_test(&data, test_async_flip);
+			}
+		}
+
 		igt_describe("Alternate between sync and async flips");
 		igt_subtest_with_dynamic("alternate-sync-async-flip") {
+			data.modifier = I915_FORMAT_MOD_X_TILED;
 			data.alternate_sync_async = true;
 			run_test(&data, test_async_flip);
 		}
 
 		igt_describe("Verify that the async flip timestamp does not coincide with either previous or next vblank");
-		igt_subtest_with_dynamic("test-time-stamp")
+		igt_subtest_with_dynamic("test-time-stamp") {
+			data.modifier = I915_FORMAT_MOD_X_TILED;
 			run_test(&data, test_timestamp);
+		}
 	}
 
 	igt_describe("Verify that the DRM_IOCTL_MODE_CURSOR passes after async flip");
@@ -622,6 +639,7 @@ igt_main_args("e", NULL, help_str, opt_handler, &data)
 			      "PSR2 sel fetch causes cursor to be added to primary plane " \
 			      "pages flips and async flip is not supported in cursor\n");
 
+		data.modifier = I915_FORMAT_MOD_X_TILED;
 		run_test(&data, test_cursor);
 	}
 
@@ -632,6 +650,7 @@ igt_main_args("e", NULL, help_str, opt_handler, &data)
 		igt_require(igt_display_has_format_mod(&data.display, DRM_FORMAT_XRGB8888,
 						       I915_FORMAT_MOD_Y_TILED));
 
+		data.modifier = I915_FORMAT_MOD_X_TILED;
 		run_test(&data, test_invalid);
 	}
 
@@ -640,6 +659,7 @@ igt_main_args("e", NULL, help_str, opt_handler, &data)
 		/* Devices without CRC can't run this test */
 		igt_require_pipe_crc(data.drm_fd);
 
+		data.modifier = I915_FORMAT_MOD_X_TILED;
 		run_test(&data, test_crc);
 	}
 
-- 
2.25.1

  parent reply	other threads:[~2022-09-05 12:01 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29  9:31 [igt-dev] [PATCH i-g-t] tests/kms_async_flips: Enable async flip on linear buffer Arun R Murthy
2022-08-29 13:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-08-31  4:08 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-08-31  9:08 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2022-09-01  2:00   ` Murthy, Arun R
2022-09-01  2:20 ` [igt-dev] [PATCHv2 " Arun R Murthy
2022-09-01  8:13   ` Juha-Pekka Heikkila
2022-09-01  2:49 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev2) Patchwork
2022-09-01 18:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-05 11:16 ` [igt-dev] [PATCHv2 i-g-t] tests/kms_async_flips: Enable async flip on linear buffer Arun R Murthy
2022-09-05 11:33   ` Jani Nikula
2022-09-05 12:01 ` Arun R Murthy [this message]
2022-11-04  4:07   ` [igt-dev] [PATCHv3 " Karthik B S
2022-12-05  4:16     ` Murthy, Arun R
2022-12-20  5:30   ` [igt-dev] [PATCHv4 " Arun R Murthy
2022-12-20  8:22     ` Karthik B S
2022-12-21  5:40   ` [igt-dev] [PATCHv5 " Arun R Murthy
2022-09-05 12:17 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev3) Patchwork
2022-09-05 13:01 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev4) Patchwork
2022-09-05 16:58 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev3) Patchwork
2022-09-05 18:31 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_async_flips: Enable async flip on linear buffer (rev4) Patchwork
2022-10-28 10:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev5) Patchwork
2022-10-28 16:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-11-09 12:38 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev6) Patchwork
2022-11-09 16:53 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-21  6:44 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev7) Patchwork
2022-11-21  8:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-11-30 13:39 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev8) Patchwork
2022-12-01  1:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-12-20 16:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev9) Patchwork
2022-12-20 19:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-12-21 11:48 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev10) Patchwork
2022-12-21 12:57 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-12-27 13:01 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Enable async flip on linear buffer (rev11) Patchwork
2022-12-27 15:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220905120150.4074178-1-arun.r.murthy@intel.com \
    --to=arun.r.murthy@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox