Re: [igt-dev] [i-g-t V3 20/52] tests/kms_multipipe_modeset: Find the suitable mode instead of using default

Modem, Bhanuprakash
2022-09-28T09:14:25Z

On Wed-28-09-2022 02:04 pm, Karthik B S wrote:
> On 9/9/2022 7:32 PM, Bhanuprakash Modem wrote:
>> This patch will add a check to Skip the subtest if a selected pipe/output
>> combo won't support Bigjoiner or 8K mode.
>>
>> Example:
>> * Pipe-D wont support a mode > 5K
>> * To use 8K mode on a pipe then consecutive pipe must be available &
>> free.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/kms_multipipe_modeset.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/tests/kms_multipipe_modeset.c
>> b/tests/kms_multipipe_modeset.c
>> index 6358d930..6ba6943e 100644
>> --- a/tests/kms_multipipe_modeset.c
>> +++ b/tests/kms_multipipe_modeset.c
>> @@ -46,6 +46,15 @@ static void run_test(data_t *data, int valid_outputs)
>>       drmModeModeInfo *mode;
>>       int i = 0;
>> +    /* Find suitable mode/resolution combo */
>> +    for_each_connected_output(display, output) {
>> +        pipe = &display->pipes[i];
>> +        igt_output_set_pipe(output, i);
>> +
>> +        i++;
>> +    }
>> +
>> igt_require(igt_override_all_active_output_modes_to_fit_bw(display));
>> +
> Agree with the idea of the patch. Please update the commit message for
> this subtest as here we're actually reducing the mode from 8k to a mode
> that can be supported on single pipe.
> With this updated the patch LGTM.

Thanks Karthik, I have floated a new rev with this change.

- Bhanu

>
> Thanks,
> Karthik.B.S
>>       for_each_connected_output(display, output) {
>>           mode = igt_output_get_mode(output);
>>           igt_assert(mode);
>
>