From: Jake Freeland <jake@technologyfriends.net>
To: igt-dev@lists.freedesktop.org
Cc: Jake Freeland <jfree@freebsd.org>
Subject: [igt-dev] [PATCH i-g-t] lib/tests/igt_fork.c: Fix error in mmap() flags
Date: Fri, 7 Oct 2022 09:52:41 -0500 [thread overview]
Message-ID: <20221007145241.44592-1-jfree@freebsd.org> (raw)
In subtest_leak(), mmap() is called with the flag PROT_WRITE,
but no PROT_READ. Later in the function, the mapped memory is
read using `children[i]`. In FreeBSD, the lack of PROT_READ
causes SIGSEGV. Adding the PROT_READ flag to the mmap() call
fixes this.
Signed-off-by: Jake Freeland <jfree@freebsd.org>
---
lib/tests/igt_fork.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/tests/igt_fork.c b/lib/tests/igt_fork.c
index d19d0945..d883aba4 100644
--- a/lib/tests/igt_fork.c
+++ b/lib/tests/igt_fork.c
@@ -109,7 +109,7 @@ __noreturn static void igt_fork_timeout_leak(void)
__noreturn static void subtest_leak(void)
{
pid_t *children =
- mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+ mmap(0, 4096, PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
const int num_children = 4096 / sizeof(*children);
igt_subtest_init(fake_argc, fake_argv);
--
2.37.0 (Apple Git-136)
next reply other threads:[~2022-10-07 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 14:52 Jake Freeland [this message]
2022-10-07 15:04 ` [igt-dev] [PATCH i-g-t] lib/tests/igt_fork.c: Fix error in mmap() flags Ville Syrjälä
2022-10-07 15:44 ` Ville Syrjälä
2022-10-07 15:35 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2022-10-07 19:10 ` Kamil Konieczny
2022-10-09 16:28 ` Vudum, Lakshminarayana
2022-10-07 19:08 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2022-10-07 20:18 ` Jake Freeland
2022-10-09 16:08 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2022-10-09 16:18 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-10-09 17:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221007145241.44592-1-jfree@freebsd.org \
--to=jake@technologyfriends.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=jfree@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox