From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: badal.nilawar@intel.com, rodrigo.vivi@intel.com
Subject: [igt-dev] [PATCH i-g-t v2 2/2] test/i915_pm_rpm: Verify bridge binds with pcieport driver
Date: Wed, 2 Nov 2022 17:28:51 +0530 [thread overview]
Message-ID: <20221102115851.2223804-3-anshuman.gupta@intel.com> (raw)
In-Reply-To: <20221102115851.2223804-1-anshuman.gupta@intel.com>
It has been observed that on some Intel x86 host,
PCI core does not bind the Intel dgfx pci card's pci bridge
devices(virtual switch ports) to the pcieport driver.
This leaves pci bridge devices to D0 state and burns power on
dgfx card. It will block the card d3cold as well.
Therefore skip the basic-pci-d3-state subtest in case of
bridge pci devices do not bind with pcieport driver.
v2:
- Commit log modification. [Rodrigo]
- Kept a separate patch for unrelated changes. [Rodrigo]
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
tests/i915/i915_pm_rpm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 017c05fde..366a3050c 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -1559,15 +1559,20 @@ static bool device_in_pci_d3(struct pci_device *pci_dev)
static void pci_d3_state_subtest(void)
{
- struct pci_device *pci_dev;
+ struct pci_device *pci_dev, *bridge_pci_dev;
igt_require(has_runtime_pm);
pci_dev = igt_device_get_pci_device(drm_fd);
+ bridge_pci_dev = pci_device_get_parent_bridge(pci_dev);
disable_all_screens_and_wait(&ms_data);
igt_assert(igt_wait(device_in_pci_d3(pci_dev), 2000, 100));
+ if (gem_has_lmem(drm_fd))
+ igt_require_f(pci_device_has_kernel_driver(bridge_pci_dev),
+ "pci bridge device does not bind with pcieport driver\n");
+
enable_one_screen_or_forcewake_get_and_wait(&ms_data);
igt_assert(!device_in_pci_d3(pci_dev));
forcewake_put(&ms_data);
--
2.25.1
next prev parent reply other threads:[~2022-11-02 11:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 11:58 [igt-dev] [PATCH i-g-t v2 0/2] test/i915_pm_rpm: Verify bridge binds with pcieport driver Anshuman Gupta
2022-11-02 11:58 ` [igt-dev] [PATCH i-g-t v2 1/2] test/i915_pm_rpm: cache pci_device Anshuman Gupta
2022-11-02 18:04 ` Rodrigo Vivi
2022-11-03 3:25 ` Nilawar, Badal
2022-11-06 13:44 ` [igt-dev] [PATCH i-g-t v2 0/2] test/i915_pm_rpm: Verify bridge binds with pcieport driver Anshuman Gupta
2022-11-06 13:44 ` [igt-dev] [PATCH i-g-t v2 1/2] test/i915_pm_rpm: cache pci_device Anshuman Gupta
2022-11-06 13:44 ` [igt-dev] [PATCH i-g-t v2 2/2] test/i915_pm_rpm: Verify bridge binds with pcieport driver Anshuman Gupta
2022-11-07 4:23 ` [igt-dev] [PATCH i-g-t v2 1/2] test/i915_pm_rpm: cache pci_device Anshuman Gupta
2022-11-07 13:35 ` Anshuman Gupta
2022-11-02 11:58 ` Anshuman Gupta [this message]
2022-11-02 18:04 ` [igt-dev] [PATCH i-g-t v2 2/2] test/i915_pm_rpm: Verify bridge binds with pcieport driver Rodrigo Vivi
2022-11-16 19:25 ` Dixit, Ashutosh
2022-11-17 8:42 ` Petri Latvala
2022-11-02 12:46 ` [igt-dev] ✗ GitLab.Pipeline: warning for test/i915_pm_rpm: Verify bridge binds with pcieport driver (rev2) Patchwork
2022-11-02 12:55 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2022-11-06 14:02 ` [igt-dev] ✗ Fi.CI.BUILD: failure for test/i915_pm_rpm: Verify bridge binds with pcieport driver (rev4) Patchwork
2022-11-07 5:07 ` [igt-dev] ✗ Fi.CI.BAT: failure for test/i915_pm_rpm: Verify bridge binds with pcieport driver (rev5) Patchwork
2022-11-07 15:49 ` [igt-dev] ✓ Fi.CI.BAT: success for test/i915_pm_rpm: Verify bridge binds with pcieport driver (rev6) Patchwork
2022-11-07 19:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-08 15:03 ` Gupta, Anshuman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102115851.2223804-3-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox