Re: [igt-dev] [PATCH i-g-t 6/6] Revert "runner: Disable socket communications for now"

Kamil Konieczny
2022-11-07T14:00:45Z

On 2022-11-07 at 14:01:51 +0200, Petri Latvala wrote:
> With a couple of fixes, using socket comms is now suitably ready for
> prime time.
>
> This reverts commit 372c56225e12578a7a4a6bcc5b79eb40b643fcde.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arek@hiler.eu>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
> runner/executor.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/runner/executor.c b/runner/executor.c
> index c6389e25..4881f71a 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -1676,14 +1676,7 @@ static int execute_next_entry(struct execute_state *state,
>
> sigprocmask(SIG_UNBLOCK, sigmask, NULL);
>
> - if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION") &&
> - getenv("IGT_RUNNER_ENABLE_SOCKET_COMMUNICATION_FIXME")) {
> - /*
> - * The variable for enabling socket comms is
> - * temporary. Do not use unless you really
> - * know what you're doing. Requiring it will
> - * go away later.
> - */
> + if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION")) {
> snprintf(envstring, sizeof(envstring), "%d", socketfd);
> setenv("IGT_RUNNER_SOCKET_FD", envstring, 1);
> }
> --
> 2.30.2
>