public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v4 1/2] lib/igt_device_scan: refactor filter adding
Date: Thu, 10 Nov 2022 13:38:03 +0100	[thread overview]
Message-ID: <20221110123804.18486-2-kamil.konieczny@linux.intel.com> (raw)
In-Reply-To: <20221110123804.18486-1-kamil.konieczny@linux.intel.com>

Refactor filter adding loop.

v2: fix misspelled word (Zbigniew)

Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/igt_device_scan.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index 15be3844..6f5b90e6 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -1775,13 +1775,15 @@ int igt_device_filter_add(const char *filters)
 
 	while ((filter = strsep(&dup, ";"))) {
 		bool is_valid = is_filter_valid(filter);
+		struct device_filter *df;
 		igt_warn_on(!is_valid);
-		if (is_valid) {
-			struct device_filter *df = malloc(sizeof(*df));
-			strncpy(df->filter, filter, sizeof(df->filter)-1);
-			igt_list_add_tail(&df->link, &device_filters);
-			count++;
-		}
+		if (!is_valid)
+			continue;
+
+		df = malloc(sizeof(*df));
+		strncpy(df->filter, filter, sizeof(df->filter)-1);
+		igt_list_add_tail(&df->link, &device_filters);
+		count++;
 	}
 
 	free(dup_orig);
-- 
2.34.1

  reply	other threads:[~2022-11-10 12:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 12:38 [igt-dev] [PATCH i-g-t v4 0/2] lib/igt_device_scan: add filer card=all Kamil Konieczny
2022-11-10 12:38 ` Kamil Konieczny [this message]
2022-11-10 12:38 ` [igt-dev] [PATCH i-g-t v4 2/2] lib/igt_device_scan: add card=all filter selector Kamil Konieczny
2022-11-10 15:52 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_device_scan: add filer card=all (rev4) Patchwork
2022-11-10 17:05 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-10 19:36   ` Kamil Konieczny
2022-11-10 22:33 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110123804.18486-2-kamil.konieczny@linux.intel.com \
    --to=kamil.konieczny@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox