From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4794910E0AB for ; Mon, 14 Nov 2022 14:10:42 +0000 (UTC) From: Petri Latvala To: igt-dev@lists.freedesktop.org Date: Mon, 14 Nov 2022 16:10:46 +0200 Message-Id: <20221114141046.2466004-1-petri.latvala@intel.com> In-Reply-To: <20221111080529.2427645-1-petri.latvala@intel.com> References: <20221111080529.2427645-1-petri.latvala@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v2] runner: Fix a memory leak in stderr_contains_warnings List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petri Latvala Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: The matches object's internals weren't released. v2: Don't leak in the other branch either. (Kamil) Signed-off-by: Petri Latvala Cc: Arkadiusz Hiler Cc: Kamil Konieczny Reviewed-by: Kamil Konieczny --- runner/resultgen.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/runner/resultgen.c b/runner/resultgen.c index 3d753828..05c4234e 100644 --- a/runner/resultgen.c +++ b/runner/resultgen.c @@ -1902,17 +1902,22 @@ static bool stderr_contains_warnings(const char *beg, const char *end) }; struct matches matches; size_t i = 0; + bool found = false; matches = find_matches(beg, end, needles); while (i < matches.size) { - if (matches.items[i].where != beg) - return true; + if (matches.items[i].where != beg) { + found = true; + break; + } beg = next_line(beg, end); i++; } - return false; + free_matches(&matches); + + return found; } static bool json_field_has_data(struct json_object *obj, const char *key) -- 2.30.2