Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] lib/i915_blt: Narrow setting same pitch and aux-ccs to Tile64 only
Date: Mon, 14 Nov 2022 18:07:21 +0100	[thread overview]
Message-ID: <20221114170721.32148-1-zbigniew.kempczynski@intel.com> (raw)

In commit 229bb0accbb7 ("lib/i915_blt: equalize pitch and aux-ccs for
full resolve") i've incidentally introduce partial regression for x-major
and Tile4.

Limit equalizing pitch and aux-ccs for full-resolve to Tile64 only.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 lib/i915/i915_blt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index a886c1d72d..3776c56c60 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -317,7 +317,7 @@ static void fill_data(struct gen12_block_copy_data *data,
 	data->dw00.special_mode = __special_mode(blt);
 	data->dw00.length = extended_command ? 20 : 10;
 
-	if (__special_mode(blt) == SM_FULL_RESOLVE) {
+	if (__special_mode(blt) == SM_FULL_RESOLVE && blt->src.tiling == T_TILE64) {
 		data->dw01.dst_pitch = blt->src.pitch - 1;
 		data->dw01.dst_aux_mode = __aux_mode(&blt->src);
 	} else {
-- 
2.34.1

             reply	other threads:[~2022-11-14 17:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 17:07 Zbigniew Kempczyński [this message]
2022-11-14 18:52 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/i915_blt: Narrow setting same pitch and aux-ccs to Tile64 only Patchwork
2022-11-16 19:15   ` Zbigniew Kempczyński
2022-11-17  2:12     ` Vudum, Lakshminarayana
2022-11-15  9:12 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2022-11-17  0:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-17 10:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221114170721.32148-1-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox