Re: [igt-dev] [i-g-t v5 32/52] tests/kms_scaling_modes: Add support for Bigjoiner

Swati Sharma
2022-12-30T17:49:01Z

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 15-Nov-22 10:38 PM, Bhanuprakash Modem wrote:
> This patch will add a check to Skip the subtest if a selected pipe/output
> combo won't support Bigjoiner or 8K mode.
>
> Example:
> * Pipe-D wont support a mode > 5K
> * To use 8K mode on a pipe then consecutive pipe must be available & free.
>
> V2: - Use updated helper name
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/kms_scaling_modes.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
> index 039e4a8d..cf637712 100644
> --- a/tests/kms_scaling_modes.c
> +++ b/tests/kms_scaling_modes.c
> @@ -93,13 +93,17 @@ static void test_scaling_mode(data_t *data, uint32_t flags)
> enum pipe pipe;
>
> for_each_pipe_with_valid_output(display, pipe, output) {
> + igt_display_reset(display);
> +
> if (!has_scaling_mode(output))
> continue;
>
> + igt_output_set_pipe(output, pipe);
> + if (!i915_pipe_output_combo_valid(display))
> + continue;
> +
> igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe))
> test_scaling_mode_on_output(display, pipe, output, flags);
> -
> - igt_display_reset(display);
> }
> }
>

--
~Swati Sharma