Re: [igt-dev] [i-g-t v6 45/52] tests/i915/kms_flip_tiling: Add support for Bigjoiner

B, Jeevan
2022-12-26T06:09:03Z

> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Friday, December 23, 2022 2:11 PM
> To: igt-dev@lists.freedesktop.org; B, Jeevan <jeevan.b@intel.com>
> Cc: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Subject: [i-g-t v6 45/52] tests/i915/kms_flip_tiling: Add support for Bigjoiner
>
> This patch will add a check to Skip the subtest if a selected pipe/output
> combo won't support Bigjoiner or 8K mode.
>
> Example:
> * Pipe-D wont support a mode > 5K
> * To use 8K mode on a pipe then consecutive pipe must be available & free.
>
> V2: - Use updated helper name
> V3: - Remove unwanted prints
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM

Reviewed-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/i915/kms_flip_tiling.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/i915/kms_flip_tiling.c b/tests/i915/kms_flip_tiling.c index
> 1183feb6..4cc063f6 100644
> --- a/tests/i915/kms_flip_tiling.c
> +++ b/tests/i915/kms_flip_tiling.c
> @@ -195,8 +195,12 @@ igt_main
> for_each_pipe_with_valid_output(&data.display, pipe,
> output) {
> igt_plane_t *plane;
>
> + igt_display_reset(&data.display);
> pipe_crc_free(&data);
> +
> igt_output_set_pipe(output, pipe);
> + if (!i915_pipe_output_combo_valid(&data.display))
> + continue;
>
> plane = igt_output_get_plane_type(output,
> DRM_PLANE_TYPE_PRIMARY);
>
> --
> 2.39.0