Re: [igt-dev] [i-g-t v5 37/52] tests/i915/kms_big_fb: Add support for Bigjoiner

B, Jeevan
2022-12-23T08:06:30Z

LGTM

Reviewed-by: Jeevan B <jeevan.b@intel.com>

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Tuesday, November 15, 2022 10:39 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [i-g-t v5 37/52] tests/i915/kms_big_fb: Add support for
> Bigjoiner
>
> This patch will add a check to Skip the subtest if a selected pipe/output
> combo won't support Bigjoiner or 8K mode.
>
> Example:
> * Pipe-D wont support a mode > 5K
> * To use 8K mode on a pipe then consecutive pipe must be available & free.
>
> V2: - Use updated helper name
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/i915/kms_big_fb.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c index
> 0beba0e1..a29a05a2 100644
> --- a/tests/i915/kms_big_fb.c
> +++ b/tests/i915/kms_big_fb.c
> @@ -406,6 +406,9 @@ static bool test_pipe(data_t *data)
> igt_plane_t *primary;
> bool ret = false;
>
> + igt_info("Using (pipe %s + %s) to run the subtest.\n",
> + kmstest_pipe_name(data->pipe), igt_output_name(data-
> >output));
> +
> if (data->format == DRM_FORMAT_C8 &&
> !igt_pipe_obj_has_prop(&data->display.pipes[data->pipe],
> IGT_CRTC_GAMMA_LUT))
> @@ -481,6 +484,10 @@ max_hw_stride_async_flip_test(data_t *data)
> igt_crc_t compare_crc, async_crc;
>
> igt_require(data->display.is_atomic);
> +
> + igt_info("Using (pipe %s + %s) to run the subtest.\n",
> + kmstest_pipe_name(data->pipe), igt_output_name(data-
> >output));
> +
> igt_output_set_pipe(data->output, data->pipe);
>
> primary = igt_output_get_plane_type(data->output,
> DRM_PLANE_TYPE_PRIMARY); @@ -592,6 +599,12 @@ static void
> test_scanout(data_t *data)
> data->format, data->modifier);
>
> for_each_pipe_with_valid_output(&data->display, data->pipe, data-
> >output) {
> + igt_display_reset(&data->display);
> +
> + igt_output_set_pipe(data->output, data->pipe);
> + if (!i915_pipe_output_combo_valid(&data->display))
> + continue;
> +
> if (data->async_flip_test) {
> if (max_hw_stride_async_flip_test(data))
> return;
> --
> 2.38.0