From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: badal.nilawar@intel.com, rodrigo.vivi@intel.com
Subject: [igt-dev] [PATCH i-g-t v4 1/5] lib/igt_pci: helpers to get PCI capabilities offset
Date: Wed, 7 Dec 2022 15:55:19 +0530 [thread overview]
Message-ID: <20221207102523.1028941-2-anshuman.gupta@intel.com> (raw)
In-Reply-To: <20221207102523.1028941-1-anshuman.gupta@intel.com>
Added helper functions to search for PCI capabilities
with help of libpciaccess library.
v2:
- Added offset == 0 check at starts of capability loop. [Badal]
- Removed unused macro and removed inline from function. [Kamil]
- Added assertion when capability offset doesn't terminate. [Kamil]
- Made find_pci_cap_offset_at() static, exported only
find_pci_cap_offset(). [Kamil]
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Co-developed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
lib/igt_pci.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++
lib/igt_pci.h | 25 ++++++++++++++++++++++
lib/meson.build | 1 +
3 files changed, 82 insertions(+)
create mode 100644 lib/igt_pci.c
create mode 100644 lib/igt_pci.h
diff --git a/lib/igt_pci.c b/lib/igt_pci.c
new file mode 100644
index 0000000000..b088835a92
--- /dev/null
+++ b/lib/igt_pci.c
@@ -0,0 +1,56 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2022 Intel Corporation
+ */
+
+#include <pciaccess.h>
+#include "igt_core.h"
+#include "igt_pci.h"
+
+static int find_pci_cap_offset_at(struct pci_device *dev, enum pci_cap_id cap_id,
+ int start_offset)
+{
+ uint8_t offset;
+ uint16_t cap_header;
+ int loop = (PCI_CFG_SPACE_SIZE - PCI_TYPE0_1_HEADER_SIZE)
+ / sizeof(cap_header);
+
+ if (pci_device_cfg_read_u8(dev, &offset, start_offset))
+ return -1;
+
+ while (loop--) {
+ igt_assert_f(offset != 0xff, "pci config space inaccessible\n");
+
+ if (!offset)
+ break;
+
+ if (offset < PCI_TYPE0_1_HEADER_SIZE)
+ break;
+
+ if (pci_device_cfg_read_u16(dev, &cap_header, (offset & 0xFC)))
+ return -1;
+
+ if (!cap_id || cap_id == (cap_header & 0xFF))
+ return offset;
+
+ offset = cap_header >> 8;
+ }
+
+ igt_fail_on_f(loop <= 0 && offset, "pci capability offset doesn't terminate\n");
+
+ return 0;
+}
+
+/**
+ * find_pci_cap_offset:
+ * @dev: pci device
+ * @cap_id: searched capability id, 0 means any capability
+ *
+ * return:
+ * -1 on config read error, 0 if capability is not found,
+ * otherwise offset at which capability with cap_id is found
+ */
+int find_pci_cap_offset(struct pci_device *dev, enum pci_cap_id cap_id)
+{
+ return find_pci_cap_offset_at(dev, cap_id, PCI_CAPS_START);
+}
diff --git a/lib/igt_pci.h b/lib/igt_pci.h
new file mode 100644
index 0000000000..7cb23a26d8
--- /dev/null
+++ b/lib/igt_pci.h
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2022 Intel Corporation
+ */
+
+#ifndef __IGT_PCI_H__
+#define __IGT_PCI_H__
+
+#include <stdint.h>
+#include <endian.h>
+
+/* forward declaration */
+struct pci_device;
+
+#define PCI_TYPE0_1_HEADER_SIZE 0x40
+#define PCI_CAPS_START 0x34
+#define PCI_CFG_SPACE_SIZE 0x100
+
+enum pci_cap_id {
+ PCI_EXPRESS_CAP_ID = 0x10
+};
+
+int find_pci_cap_offset(struct pci_device *dev, enum pci_cap_id cap_id);
+
+#endif
diff --git a/lib/meson.build b/lib/meson.build
index 8ae9fe13d1..f4a0bdc29a 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -33,6 +33,7 @@ lib_sources = [
'igt_pipe_crc.c',
'igt_power.c',
'igt_primes.c',
+ 'igt_pci.c',
'igt_rand.c',
'igt_stats.c',
'igt_syncobj.c',
--
2.25.1
next prev parent reply other threads:[~2022-12-07 10:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 10:25 [igt-dev] [PATCH i-g-t v4 0/5] Cold Reset IGT Test Anshuman Gupta
2022-12-07 10:25 ` Anshuman Gupta [this message]
2022-12-07 13:09 ` [igt-dev] [PATCH i-g-t v4 1/5] lib/igt_pci: helpers to get PCI capabilities offset Nilawar, Badal
2022-12-08 8:00 ` Bernatowicz, Marcin
2022-12-09 12:40 ` Anshuman Gupta
2022-12-07 10:25 ` [igt-dev] [PATCH i-g-t v4 2/5] lib/igt_pci: Add PCIe slot cap Anshuman Gupta
2022-12-07 10:25 ` [igt-dev] [PATCH i-g-t v4 3/5] lib/igt_pm: Refactor get firmware_node fd Anshuman Gupta
2022-12-07 10:25 ` [igt-dev] [PATCH i-g-t v4 4/5] test/device_reset: Refactor initiate_device_reset Anshuman Gupta
2022-12-07 10:25 ` [igt-dev] [PATCH i-g-t v4 5/5] tests/device_reset: Add cold reset IGT test Anshuman Gupta
2022-12-07 13:15 ` Nilawar, Badal
2022-12-07 10:59 ` [igt-dev] ✓ Fi.CI.BAT: success for Cold Reset IGT Test Patchwork
2022-12-07 12:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-12-09 13:28 ` [igt-dev] ✓ Fi.CI.BAT: success for Cold Reset IGT Test (rev2) Patchwork
2022-12-09 21:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207102523.1028941-2-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox