public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 1/3] lib/i915_blt: Remove src == dst pitch restriction
Date: Thu, 15 Dec 2022 12:35:17 +0100	[thread overview]
Message-ID: <20221215113519.36660-2-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20221215113519.36660-1-zbigniew.kempczynski@intel.com>

During debugging phase we established there's not necessary to enforce
same pitch for destination surface in FULL_RESOLVE mode. Relax this
condition allowing caller to pass requirement surface configuration.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Karolina Stolarek <karolina.stolarek@intel.com>
Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/i915_blt.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index 3776c56c60..42c28623f9 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -317,13 +317,11 @@ static void fill_data(struct gen12_block_copy_data *data,
 	data->dw00.special_mode = __special_mode(blt);
 	data->dw00.length = extended_command ? 20 : 10;
 
-	if (__special_mode(blt) == SM_FULL_RESOLVE && blt->src.tiling == T_TILE64) {
-		data->dw01.dst_pitch = blt->src.pitch - 1;
+	if (__special_mode(blt) == SM_FULL_RESOLVE)
 		data->dw01.dst_aux_mode = __aux_mode(&blt->src);
-	} else {
-		data->dw01.dst_pitch = blt->dst.pitch - 1;
+	else
 		data->dw01.dst_aux_mode = __aux_mode(&blt->dst);
-	}
+	data->dw01.dst_pitch = blt->dst.pitch - 1;
 
 	data->dw01.dst_mocs = blt->dst.mocs;
 	data->dw01.dst_compression = blt->dst.compression;
-- 
2.34.1

  reply	other threads:[~2022-12-15 11:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15 11:35 [igt-dev] [PATCH i-g-t v2 0/3] Add block-multicopy-* subtests Zbigniew Kempczyński
2022-12-15 11:35 ` Zbigniew Kempczyński [this message]
2022-12-15 11:35 ` [igt-dev] [PATCH i-g-t v2 2/3] lib/i915_blt: Extract blit emit functions Zbigniew Kempczyński
2022-12-15 11:35 ` [igt-dev] [PATCH i-g-t v2 3/3] tests/gem_ccs: Add block-multicopy subtest Zbigniew Kempczyński
2022-12-19  8:23   ` Karolina Stolarek
2022-12-15 14:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Add block-multicopy-* subtests (rev2) Patchwork
2022-12-16 13:37 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-12-19  8:02   ` Zbigniew Kempczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221215113519.36660-2-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox