From: Alan Previn <alan.previn.teres.alexis@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Subject: [igt-dev] [PATCH i-g-t v2 1/1] tests/i915/pxp: PXP debugfs path promoted to global
Date: Mon, 19 Dec 2022 11:20:48 -0800 [thread overview]
Message-ID: <20221219192048.2283294-1-alan.previn.teres.alexis@intel.com> (raw)
As per recent kernel side update in preparation for
MTL, PXP is now a global i915 subsystem so let's update
the debugfs path to try both the legacy and new paths
before we fail.
Changes from prior rev:
v1: - Fix a comment (Daniele)
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
tests/i915/gem_pxp.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tests/i915/gem_pxp.c b/tests/i915/gem_pxp.c
index ffad9b5a..41043df9 100644
--- a/tests/i915/gem_pxp.c
+++ b/tests/i915/gem_pxp.c
@@ -848,6 +848,14 @@ static void trigger_pxp_debugfs_forced_teardown(int i915)
char str[32];
fd = igt_debugfs_open(i915, "gt/pxp/terminate_state", O_RDWR);
+ /*
+ * On newer kernels, we promoted PXP to be a global i915 subsystem,
+ * so try again with a top-level path if we failed at the gt path.
+ * If we still fail, then we assert out.
+ */
+ if (fd < 0)
+ fd = igt_debugfs_open(i915, "pxp/terminate_state", O_RDWR);
+
igt_assert_f(fd >= 0, "Can't open pxp termination debugfs\n");
ret = snprintf(str, sizeof(str), "0x1");
igt_assert(ret > 2 && ret < sizeof(str));
base-commit: c001793d5f22deb01918b6ba52af829794582df1
--
2.34.1
next reply other threads:[~2022-12-19 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 19:20 Alan Previn [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-12-15 17:43 [igt-dev] [PATCH i-g-t v2 1/1] tests/i915/pxp: PXP debugfs path promoted to global Alan Previn
2022-12-15 18:30 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219192048.2283294-1-alan.previn.teres.alexis@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox