From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: lucas.demarchi@intel.com
Subject: [igt-dev] [PATCH i-g-t v3] lib/igt_draw: Change MOCS settings for MTL
Date: Tue, 20 Dec 2022 10:09:43 +0530 [thread overview]
Message-ID: <20221220043943.17796-1-jeevan.b@intel.com> (raw)
On MTL, we want the table entry labelled "UC (GO:Mem)"
which has index 5. This means that the MOCS value is 10.
v2: Add define for MOCS settings. (Lucas)
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
lib/igt_draw.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 975d65cd..e9b427f7 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -651,13 +651,16 @@ static struct intel_buf *create_buf(int fd, struct buf_ops *bops,
return buf;
}
+#define DG2_MOCS_UC_GO_MEM 2 /* MOCS index 0x1 */
+#define MTL_MOCS_UC_GO_MEM 10 /* MOCS index 0x5 */
+
static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
struct buf_data *buf, struct rect *rect,
uint32_t tiling, uint32_t color)
{
struct intel_bb *ibb;
struct intel_buf *dst;
- int blt_cmd_len, blt_cmd_tiling, blt_cmd_depth;
+ int blt_cmd_len, blt_cmd_tiling, blt_cmd_depth, mocs_val;
uint32_t devid = intel_get_drm_devid(fd);
int gen = intel_gen(devid);
int pitch;
@@ -699,11 +702,15 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
igt_assert(false);
}
+ if (IS_METEORLAKE(intel_get_drm_devid(fd)))
+ mocs_val = MTL_MOCS_UC_GO_MEM;
+ else
+ mocs_val = DG2_MOCS_UC_GO_MEM;
+
pitch = tiling ? buf->stride / 4 : buf->stride;
intel_bb_out(ibb, XY_FAST_COLOR_BLT | blt_cmd_depth);
- /* DG2 MOCS entry 2 is "UC - Non-Coherent; GO:Memory" */
- intel_bb_out(ibb, blt_cmd_tiling | 2 << 21 | (pitch-1));
+ intel_bb_out(ibb, blt_cmd_tiling | mocs_val << 21 | (pitch-1));
intel_bb_out(ibb, (rect->y << 16) | rect->x);
intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
intel_bb_emit_reloc_fenced(ibb, dst->handle, 0,
--
2.36.0
next reply other threads:[~2022-12-20 4:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 4:39 Jeevan B [this message]
2022-12-20 16:00 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_draw: Change MOCS settings for MTL (rev4) Patchwork
2022-12-20 19:03 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-12-22 9:36 [igt-dev] [PATCH i-g-t v3] lib/igt_draw: Change MOCS settings for MTL Jeevan B
2022-12-22 9:38 Jeevan B
2022-12-22 15:35 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220043943.17796-1-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox