Re: [igt-dev] [PATCH i-g-t 0/2] Tests for V3D/VC4 Mmap BO IOCTLs

[Melissa Wen <mwen@igalia.com>]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

On 12/23, Maíra Canal wrote:
> Currently, the Mmap BO IOCTL is not completely covered by the existing tests:
> V3D only tests invalid BO handlers and VC4 doesn't have tests for this IOCTL.
> Therefore, create tests for the Mmap BO IOCTL for the V3D and VC4. For both
> drivers, the sub-tests will test invalid parameters and also the consistency
> of newly mapped BOs.
> 
> Best Regards,
> - Maíra Canal
> 
> Maíra Canal (2):
>   tests/v3d_mmap: Improve tests from V3D's Mmap BO IOCTL
>   tests/vc4_mmap: Create test for VC4's Mmap BO IOCTL
Hi Maíra,

Just that comment about coherency that doesn't fit well in these tests.
Otherwise, this series LGTM.

Reviewed-by: Melissa Wen <mwen@igalia.com>
> 
>  lib/igt_v3d.c             |  2 ++
>  lib/igt_vc4.c             |  2 ++
>  tests/v3d/v3d_mmap.c      | 34 ++++++++++++++++++++++++
>  tests/v3d_ci/v3d.testlist |  2 ++
>  tests/vc4/meson.build     |  1 +
>  tests/vc4/vc4_mmap.c      | 55 +++++++++++++++++++++++++++++++++++++++
>  tests/vc4_ci/vc4.testlist |  2 ++
>  7 files changed, 98 insertions(+)
>  create mode 100644 tests/vc4/vc4_mmap.c
> 
> -- 
> 2.38.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]