public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t v6 32/50] tests/kms_universal_plane: Add support for Bigjoiner
Date: Fri, 30 Dec 2022 23:18:07 +0530	[thread overview]
Message-ID: <20221230174825.3016716-33-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20221230174825.3016716-1-bhanuprakash.modem@intel.com>

This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.

Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.

V2: - Use updated helper name

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Ananya Sharma <ananya.sharma@intel.com>
---
 tests/kms_universal_plane.c | 94 +++++++++++++++++++++++++++++++++----
 1 file changed, 84 insertions(+), 10 deletions(-)

diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index dd8fa193..2a9eb021 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -381,6 +381,9 @@ sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 
 	igt_require_pipe(&data->display, pipe);
 
+	igt_info("Using (pipe %s + %s) to run the subtest.\n",
+		 kmstest_pipe_name(pipe), igt_output_name(output));
+
 	igt_output_set_pipe(output, pipe);
 	mode = igt_output_get_mode(output);
 
@@ -494,6 +497,9 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 
 	igt_require_pipe(&data->display, pipe);
 
+	igt_info("Using (pipe %s + %s) to run the subtest.\n",
+		 kmstest_pipe_name(pipe), igt_output_name(output));
+
 	igt_output_set_pipe(output, pipe);
 
 	pageflip_test_init(&test, output, pipe);
@@ -604,6 +610,9 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_require(display->has_cursor_plane);
 	igt_require_intel(data->drm_fd);
 
+	igt_info("Using (pipe %s + %s) to run the subtest.\n",
+		 kmstest_pipe_name(pipe), igt_output_name(output));
+
 	igt_output_set_pipe(output, pipe);
 	mode = igt_output_get_mode(output);
 
@@ -731,6 +740,9 @@ pageflip_win_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_skip_on(is_i915_device(data->drm_fd) && data->display_ver < 9);
 	igt_require_pipe(&data->display, pipe);
 
+	igt_info("Using (pipe %s + %s) to run the subtest.\n",
+		 kmstest_pipe_name(pipe), igt_output_name(output));
+
 	igt_output_set_pipe(output, pipe);
 
 	gen9_test_init(&test, output, pipe);
@@ -766,6 +778,22 @@ pageflip_win_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	gen9_test_fini(&test, output);
 }
 
+static bool
+pipe_output_combo_valid(igt_display_t *display,
+			enum pipe pipe, igt_output_t *output)
+{
+	bool ret = true;
+
+	igt_display_reset(display);
+
+	igt_output_set_pipe(output, pipe);
+	if (!i915_pipe_output_combo_valid(display))
+		ret = false;
+	igt_output_set_pipe(output, PIPE_NONE);
+
+	return ret;
+}
+
 static void
 run_tests_for_pipe(data_t *data, enum pipe pipe)
 {
@@ -784,34 +812,79 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
 
 	igt_describe("Check the switching between different primary plane fbs with CRTC off");
 	igt_subtest_f("universal-plane-pipe-%s-functional",
-		      kmstest_pipe_name(pipe))
-		for_each_valid_output_on_pipe(&data->display, pipe, output)
+		      kmstest_pipe_name(pipe)) {
+		bool found = false;
+
+		for_each_valid_output_on_pipe(&data->display, pipe, output) {
+			if (!pipe_output_combo_valid(&data->display, pipe, output))
+				continue;
+
+			found = true;
 			functional_test_pipe(data, pipe, output);
+		}
+		igt_require_f(found, "No valid pipe/output combo found.\n");
+	}
 
 	igt_describe("Test for scale-up or scale-down using universal plane API without covering CRTC");
 	igt_subtest_f("universal-plane-pipe-%s-sanity",
-		      kmstest_pipe_name(pipe))
-		for_each_valid_output_on_pipe(&data->display, pipe, output)
+		      kmstest_pipe_name(pipe)) {
+		bool found = false;
+
+		for_each_valid_output_on_pipe(&data->display, pipe, output) {
+			if (!pipe_output_combo_valid(&data->display, pipe, output))
+				continue;
+
+			found = true;
 			sanity_test_pipe(data, pipe, output);
+		}
+		igt_require_f(found, "No valid pipe/output combo found.\n");
+	}
 
 	igt_describe("Check pageflips while primary plane is disabled before IOCTL or between IOCTL"
 			" and pageflip execution");
 	igt_subtest_f("disable-primary-vs-flip-pipe-%s",
-		      kmstest_pipe_name(pipe))
-		for_each_valid_output_on_pipe(&data->display, pipe, output)
+		      kmstest_pipe_name(pipe)) {
+		bool found = false;
+
+		for_each_valid_output_on_pipe(&data->display, pipe, output) {
+			if (!pipe_output_combo_valid(&data->display, pipe, output))
+				continue;
+
+			found = true;
 			pageflip_test_pipe(data, pipe, output);
+		}
+		igt_require_f(found, "No valid pipe/output combo found.\n");
+	}
 
 	igt_describe("Check for cursor leaks after performing cursor operations");
 	igt_subtest_f("cursor-fb-leak-pipe-%s",
-		      kmstest_pipe_name(pipe))
-		for_each_valid_output_on_pipe(&data->display, pipe, output)
+		      kmstest_pipe_name(pipe)) {
+		bool found = false;
+
+		for_each_valid_output_on_pipe(&data->display, pipe, output) {
+			if (!pipe_output_combo_valid(&data->display, pipe, output))
+				continue;
+
+			found = true;
 			cursor_leak_test_pipe(data, pipe, output);
+		}
+		igt_require_f(found, "No valid pipe/output combo found.\n");
+	}
 
 	igt_describe("Check if pageflip succeeds in windowed setting");
 	igt_subtest_f("universal-plane-pageflip-windowed-pipe-%s",
-		      kmstest_pipe_name(pipe))
-		for_each_valid_output_on_pipe(&data->display, pipe, output)
+		      kmstest_pipe_name(pipe)) {
+		bool found = false;
+
+		for_each_valid_output_on_pipe(&data->display, pipe, output) {
+			if (!pipe_output_combo_valid(&data->display, pipe, output))
+				continue;
+
+			found = true;
 			pageflip_win_test_pipe(data, pipe, output);
+		}
+		igt_require_f(found, "No valid pipe/output combo found.\n");
+	}
 }
 
 static data_t data;
@@ -829,6 +902,7 @@ igt_main
 
 		igt_require_pipe_crc(data.drm_fd);
 		igt_display_require(&data.display, data.drm_fd);
+		igt_display_require_output(&data.display);
 	}
 
 	for_each_pipe_static(pipe) {
-- 
2.39.0

  parent reply	other threads:[~2022-12-30 17:52 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30 17:47 [igt-dev] [i-g-t v6 00/50] Add IGT support for Bigjoiner Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 01/50] lib/igt_kms: Add a helper for valid pipe/output constraint Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 02/50] lib/igt_kms: Bigjoiner check in max_bpc constraint Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 03/50] tests/kms_async_flips: Add support for Bigjoiner Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 04/50] tests/kms_atomic: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 05/50] tests/kms_atomic_interruptible: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 06/50] tests/kms_atomic_transition: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 07/50] tests/kms_color_helper: Helper to check Bigjoiner constraint Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 08/50] tests/kms_color: Add support for Bigjoiner Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 09/50] tests/chamelium/kms_color_chamelium: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 10/50] tests/kms_concurrent: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 11/50] tests/kms_cursor_crc: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 12/50] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 13/50] tests/kms_cursor_legacy: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 14/50] tests/kms_display_modes: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 15/50] tests/kms_dp_tiled_display: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 16/50] tests/kms_flip_event_leak: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 17/50] tests/kms_invalid_mode: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 18/50] tests/kms_lease: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 19/50] tests/kms_pipe_crc_basic: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 20/50] tests/kms_plane: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 21/50] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 22/50] tests/kms_plane_cursor: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 23/50] tests/kms_plane_lowres: " Bhanuprakash Modem
2022-12-30 17:47 ` [igt-dev] [i-g-t v6 24/50] tests/kms_plane_multiple: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 25/50] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-01-04  7:36   ` Swati Sharma
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 26/50] tests/kms_prime: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 27/50] tests/kms_properties: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 28/50] tests/kms_rmfb: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 29/50] tests/kms_rotation_crc: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 30/50] tests/kms_scaling_modes: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 31/50] tests/kms_sequence: " Bhanuprakash Modem
2022-12-30 17:48 ` Bhanuprakash Modem [this message]
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 33/50] tests/kms_vblank: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 34/50] tests/kms_vrr: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 35/50] tests/i915/kms_big_fb: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 36/50] tests/i915/kms_big_joiner: Negative tests " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 37/50] tests/i915/kms_busy: Add support " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 38/50] tests/i915/kms_ccs: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 39/50] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-01-04  7:33   ` Swati Sharma
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 40/50] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 41/50] tests/i915/kms_fence_pin_leak: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 42/50] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 43/50] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 44/50] tests/i915/kms_frontbuffer_tracking: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 45/50] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 46/50] tests/i915/kms_psr2_sf: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 47/50] tests/i915/kms_psr2_su: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 48/50] tests/i915/kms_psr: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 49/50] tests/i915/kms_psr_stress_test: " Bhanuprakash Modem
2022-12-30 17:48 ` [igt-dev] [i-g-t v6 50/50] tests/i915/kms_pwrite_crc: " Bhanuprakash Modem
2022-12-30 18:30 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT support for Bigjoiner (rev17) Patchwork
2022-12-30 20:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221230174825.3016716-33-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox