From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t] chamelium: Ignore errors when fetching AdapterAllowed
Date: Tue, 3 Jan 2023 15:30:49 +0200 [thread overview]
Message-ID: <20230103133049.30169-1-petri.latvala@intel.com> (raw)
Not setting AdapterAllowed in .igtrc should be considered a valid
configuration. The default value of 'false' from
g_key_file_get_boolean when the field is missing is exactly what we
want to use, and storing the missing field error in the 'error'
variable leads to an error such as
(kms_chamelium:1713) igt_chamelium-WARNING: Failed to read chamelium port ID for DP-3: Key file does not have key “AdapterAllowed” in group “Chamelium:HDMI-A-2”
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Ryszard Knop <ryszard.knop@intel.com>
---
lib/igt_chamelium.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 79920de1..6506330e 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -2477,7 +2477,7 @@ static bool chamelium_read_port_mappings(struct chamelium *chamelium,
}
port->adapter_allowed = g_key_file_get_boolean(igt_key_file, group,
- "AdapterAllowed", &error);
+ "AdapterAllowed", NULL);
for (j = 0;
j < res->count_connectors && !port->connector_id;
--
2.30.2
next reply other threads:[~2023-01-03 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 13:30 Petri Latvala [this message]
2023-01-03 15:54 ` [igt-dev] ✓ Fi.CI.BAT: success for chamelium: Ignore errors when fetching AdapterAllowed Patchwork
2023-01-04 0:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-01-04 13:01 ` [igt-dev] [PATCH i-g-t] " Knop, Ryszard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103133049.30169-1-petri.latvala@intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox