Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Maíra Canal" <mcanal@igalia.com>
To: "Melissa Wen" <mwen@igalia.com>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Petri Latvala" <petri.latvala@intel.com>,
	"Maxime Ripard" <maxime@cerno.tech>
Cc: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 2/3] tests/vc4_perfmon: Make sure vc4 supports perfmon
Date: Tue,  3 Jan 2023 14:52:44 -0300	[thread overview]
Message-ID: <20230103175244.958771-3-mcanal@igalia.com> (raw)
In-Reply-To: <20230103175244.958771-1-mcanal@igalia.com>

Performance Monitors for the vc4 were introduced in Linux 4.17, so a
check if vc4 supports Performance Monitors is essential to assure that
the tests will perform correctly. Therefore, check if vc4 has
perfmon support before running the tests.

Reviewed-by: Melissa Wen <mwen@igalia.com>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 tests/vc4/vc4_perfmon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/vc4/vc4_perfmon.c b/tests/vc4/vc4_perfmon.c
index 30186519..664633a3 100644
--- a/tests/vc4/vc4_perfmon.c
+++ b/tests/vc4/vc4_perfmon.c
@@ -15,6 +15,7 @@ igt_main
 	igt_fixture {
 		fd = drm_open_driver(DRIVER_VC4);
 		igt_require(igt_vc4_is_v3d(fd));
+		igt_require(igt_vc4_get_param(fd, DRM_VC4_PARAM_SUPPORTS_PERFMON));
 	}
 
 	igt_describe("Make sure a perfmon cannot be created with zero counters.");
-- 
2.38.1

  parent reply	other threads:[~2023-01-03 17:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-03 17:52 [igt-dev] [PATCH i-g-t v3 0/3] Make sure v3d/vc4 support performance monitors Maíra Canal
2023-01-03 17:52 ` [igt-dev] [PATCH i-g-t v3 1/3] lib/igt_vc4: Rework igt_vc4_get_param() Maíra Canal
2023-01-11 18:04   ` Melissa Wen
2023-01-03 17:52 ` Maíra Canal [this message]
2023-01-03 17:52 ` [igt-dev] [PATCH i-g-t v3 3/3] tests/v3d_perfmon: Make sure v3d supports perfmon Maíra Canal
2023-01-03 19:19 ` [igt-dev] ✗ Fi.CI.BAT: failure for Make sure v3d/vc4 support performance monitors (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230103175244.958771-3-mcanal@igalia.com \
    --to=mcanal@igalia.com \
    --cc=andrealmeid@igalia.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=maxime@cerno.tech \
    --cc=mwen@igalia.com \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox