public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t v7 34/51] tests/kms_vblank: Add support for Bigjoiner
Date: Wed,  4 Jan 2023 22:30:06 +0530	[thread overview]
Message-ID: <20230104170023.3355190-35-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230104170023.3355190-1-bhanuprakash.modem@intel.com>

This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.

Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.

V2: - Use updated helper name

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_vblank.c | 54 ++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 52 insertions(+), 2 deletions(-)

diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index 5bd3fefe..f6863af0 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -175,6 +175,22 @@ static void run_test(data_t *data, void (*testfunc)(data_t *, int, int))
 	cleanup_crtc(data, fd, output);
 }
 
+static bool
+pipe_output_combo_valid(igt_display_t *display,
+			enum pipe pipe, igt_output_t *output)
+{
+	bool ret = true;
+
+	igt_display_reset(display);
+
+	igt_output_set_pipe(output, pipe);
+	if (!i915_pipe_output_combo_valid(display))
+		ret = false;
+	igt_output_set_pipe(output, PIPE_NONE);
+
+	return ret;
+}
+
 static void crtc_id_subtest(data_t *data, int fd)
 {
 	igt_display_t *display = &data->display;
@@ -188,6 +204,15 @@ static void crtc_id_subtest(data_t *data, int fd)
 		uint64_t val;
 		union drm_wait_vblank vbl;
 
+		igt_display_reset(display);
+
+		igt_output_set_pipe(output, p);
+		if (!i915_pipe_output_combo_valid(display))
+			continue;
+
+		igt_info("Using (pipe %s + %s) to run the subtest.\n",
+			 kmstest_pipe_name(p), igt_output_name(output));
+
 		crtc_id = display->pipes[p].crtc_id;
 		if (drmGetCap(display->drm_fd, DRM_CAP_CRTC_IN_VBLANK_EVENT, &val) == 0)
 			expected_crtc_id = crtc_id;
@@ -449,10 +474,18 @@ static void run_subtests_for_pipe(data_t *data)
 			igt_subtest_f("pipe-%s-%s-%s",
 				      kmstest_pipe_name(data->pipe),
 				      f->name, m->name) {
+				int found = 0;
+
 				for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
+					if (!pipe_output_combo_valid(&data->display, data->pipe, data->output))
+						continue;
+
 					data->flags = m->flags | NOHANG;
 					run_test(data, f->func);
+
+					found++;
 				}
+				igt_require_f(found, "No valid pipe/output combo found.\n");
 			}
 
 			/* Skip the -hang version if NOHANG flag is set */
@@ -464,13 +497,20 @@ static void run_subtests_for_pipe(data_t *data)
 				      kmstest_pipe_name(data->pipe),
 				      f->name, m->name) {
 				igt_hang_t hang;
+				int found = 0;
 
 				hang = igt_allow_hang(data->display.drm_fd, 0, 0);
 				for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
+					if (!pipe_output_combo_valid(&data->display, data->pipe, data->output))
+						continue;
+
 					data->flags = m->flags;
 					run_test(data, f->func);
+
+					found++;
 				}
 				igt_disallow_hang(data->display.drm_fd, hang);
+				igt_require_f(found, "No valid pipe/output combo found.\n");
 			}
 		}
 	}
@@ -482,12 +522,22 @@ static void invalid_subtest(data_t *data, int fd)
 	unsigned long valid_flags;
 	igt_display_t* display = &data->display;
 	enum pipe pipe = 0;
-	igt_output_t* output = igt_get_single_output_for_pipe(display, pipe);
+	igt_output_t *output;
+
+	igt_display_reset(display);
+
+	output = igt_get_single_output_for_pipe(display, pipe);
+	igt_require(output);
 
 	data->pipe = pipe;
 	data->output = output;
+
 	igt_output_set_pipe(output, pipe);
-	igt_display_require_output_on_pipe(display, pipe);
+	igt_require(i915_pipe_output_combo_valid(display));
+
+	igt_info("Using (pipe %s + %s) to run the subtest.\n",
+		 kmstest_pipe_name(pipe), igt_output_name(output));
+
 	prepare_crtc(data, fd, output);
 
 	/* First check all is well with a simple query */
-- 
2.39.0

  parent reply	other threads:[~2023-01-04 17:08 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 16:59 [igt-dev] [i-g-t v7 00/51] Add IGT support for Bigjoiner Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 01/51] lib/igt_kms: Add a helper for valid pipe/output constraint Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 02/51] lib/igt_kms: Bigjoiner check in max_bpc constraint Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 03/51] tests/kms_async_flips: Add support for Bigjoiner Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 04/51] tests/kms_atomic: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 05/51] tests/kms_atomic_interruptible: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 06/51] tests/kms_atomic_transition: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 07/51] tests/kms_color_helper: Helper to check Bigjoiner constraint Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 08/51] tests/kms_color: Add support for Bigjoiner Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 09/51] tests/chamelium/kms_color_chamelium: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 10/51] tests/kms_content_protection: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 11/51] tests/kms_concurrent: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 12/51] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-01-18 16:23   ` [igt-dev] [i-g-t v8 " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 13/51] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 14/51] tests/kms_cursor_legacy: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 15/51] tests/kms_display_modes: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 16/51] tests/kms_dp_tiled_display: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 17/51] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 18/51] tests/kms_invalid_mode: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 19/51] tests/kms_lease: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 20/51] tests/kms_pipe_crc_basic: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 21/51] tests/kms_plane: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 22/51] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 23/51] tests/kms_plane_cursor: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 24/51] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 25/51] tests/kms_plane_multiple: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 26/51] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-01-04 16:59 ` [igt-dev] [i-g-t v7 27/51] tests/kms_prime: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 28/51] tests/kms_properties: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 29/51] tests/kms_rmfb: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 30/51] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 31/51] tests/kms_scaling_modes: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 32/51] tests/kms_sequence: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 33/51] tests/kms_universal_plane: " Bhanuprakash Modem
2023-01-04 17:00 ` Bhanuprakash Modem [this message]
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 35/51] tests/kms_vrr: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 36/51] tests/i915/kms_big_fb: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 37/51] tests/i915/kms_big_joiner: Negative tests " Bhanuprakash Modem
2023-01-18 16:23   ` [igt-dev] [i-g-t v8 " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 38/51] tests/i915/kms_busy: Add support " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 39/51] tests/i915/kms_ccs: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 40/51] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 41/51] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 42/51] tests/i915/kms_fence_pin_leak: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 43/51] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 44/51] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 45/51] tests/i915/kms_frontbuffer_tracking: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 46/51] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 47/51] tests/i915/kms_psr2_sf: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 48/51] tests/i915/kms_psr2_su: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 49/51] tests/i915/kms_psr: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 50/51] tests/i915/kms_psr_stress_test: " Bhanuprakash Modem
2023-01-04 17:00 ` [igt-dev] [i-g-t v7 51/51] tests/i915/kms_pwrite_crc: " Bhanuprakash Modem
2023-01-04 19:05 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT support for Bigjoiner (rev18) Patchwork
2023-01-05  1:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-01-18 19:34 ` [igt-dev] ✓ Fi.CI.BAT: success for Add IGT support for Bigjoiner (rev20) Patchwork
2023-01-19 18:09 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230104170023.3355190-35-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox