public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: suresh.kumar.kurmi@intel.com, dnyaneshwar.bhadane@intel.com,
	juha-pekka.heikkila@intel.com, chaitanya.kumar.borah@intel.com
Subject: [igt-dev] [i-g-t v2] tests/kms_cursor_crc: Skip for invalid pipe connector connection
Date: Mon,  9 Jan 2023 12:19:05 +0530	[thread overview]
Message-ID: <20230109064905.280139-1-dnyaneshwar.bhadane@intel.com> (raw)
In-Reply-To: <20221230064638.155300-1-dnyaneshwar.bhadane@intel.com>

Added a skip condition that checks for the valid pipe connection. This is a 
generic skip on pipe which checks for valid connector connection mask bit. 
This condition helps to skip tests for MSO panels on non supported pipes
(C and D).This condition was missed for cursor-size-change,
cursor-alpha-opaque and cursor-alpha-transparent testcases.

--v2
- Change commit messege  from "Add Gaurd for MSO eDP for Pipe C and D"
to "Skip condition for non valid pipe connector connection" [Kamil]
- skip condition using igt_pipe_connector_valid() [Juha-Pekka]

Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

---
 tests/kms_cursor_crc.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 17f294d6..87497b9e 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -786,6 +786,13 @@ static void run_tests_on_pipe(data_t *data)
 	igt_subtest_with_dynamic("cursor-size-change") {
 		for_each_pipe(&data->display, pipe) {
 			data->pipe = pipe;
+			
+			if(!igt_pipe_connector_valid(pipe, data->output)) {
+				igt_debug("Invalid connector on pipe-%s-%s",
+				      kmstest_pipe_name(pipe),
+				      data->output->name);
+				continue;
+			}
 
 			igt_dynamic_f("pipe-%s-%s",
 				      kmstest_pipe_name(pipe),
@@ -800,6 +807,13 @@ static void run_tests_on_pipe(data_t *data)
 	igt_subtest_with_dynamic("cursor-alpha-opaque") {
 		for_each_pipe(&data->display, pipe) {
 			data->pipe = pipe;
+			
+			if(!igt_pipe_connector_valid(pipe, data->output)) {
+				igt_debug("Invalid connector on pipe-%s-%s",
+				      kmstest_pipe_name(pipe),
+				      data->output->name);
+				continue;
+			}
 
 			igt_dynamic_f("pipe-%s-%s",
 				      kmstest_pipe_name(pipe),
@@ -814,6 +828,13 @@ static void run_tests_on_pipe(data_t *data)
 	igt_subtest_with_dynamic("cursor-alpha-transparent") {
 		for_each_pipe(&data->display, pipe) {
 			data->pipe = pipe;
+			
+			if(!igt_pipe_connector_valid(pipe, data->output)) {
+				igt_debug("Invalid connector on pipe-%s-%s",
+				      kmstest_pipe_name(pipe),
+				      data->output->name);
+				continue;
+			}
 
 			igt_dynamic_f("pipe-%s-%s",
 				      kmstest_pipe_name(pipe),
-- 
2.35.1

  parent reply	other threads:[~2023-01-09  6:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30  6:46 [igt-dev] [i-g-t] tests/kms_cursor_crc: Add Gaurd for MSO eDP for Pipe C and D bhadanednyaneshwar
2022-12-30 10:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-12-30 11:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-12-30 19:16 ` [igt-dev] [i-g-t] " Swati Sharma
2023-01-03  5:59   ` Bhadane, Dnyaneshwar
2023-01-03 14:50 ` Kamil Konieczny
2023-01-05  6:26   ` Bhadane, Dnyaneshwar
2023-01-03 17:41 ` Kamil Konieczny
2023-01-05  6:22   ` Bhadane, Dnyaneshwar
2023-01-03 18:31 ` Juha-Pekka Heikkila
2023-01-05  8:07   ` Bhadane, Dnyaneshwar
2023-01-06 12:28   ` Bhadane, Dnyaneshwar
2023-01-09  6:49 ` Dnyaneshwar Bhadane [this message]
2023-01-09 15:19   ` [igt-dev] [i-g-t v2] tests/kms_cursor_crc: Skip for invalid pipe connector connection Juha-Pekka Heikkila
2023-01-09  7:18 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cursor_crc: Add Gaurd for MSO eDP for Pipe C and D (rev2) Patchwork
2023-01-09  7:52 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_crc: Add Gaurd for MSO eDP for Pipe C and D (rev3) Patchwork
2023-01-09  9:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230109064905.280139-1-dnyaneshwar.bhadane@intel.com \
    --to=dnyaneshwar.bhadane@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    --cc=suresh.kumar.kurmi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox