Re: [igt-dev] [RFC PATCH 0/1] Initial Xe test suite

[Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>]

Hi Matthew,

On Thu, 22 Dec 2022 14:47:46 -0800
Matthew Brost <matthew.brost@intel.com> wrote:

> Initial Xe test suite for new Xe Intel GPU driver [1]. All major features of the
> Xe uAPI and all internal code paths should have some basic coverage. Before
> these new tests are upstreamed proper commit messages for each test will be
> included plus kerneldoc describing what each test is testing and the
> methodology. For the time being we are just including 1 large patch.

I pinged some reviewers to take a look on those changes. The feedback
I got is that, in order to make easier to reviews, the best would be
if you could split this patch into a series...
> 
> Cheers,
> Matthew Brost
> 
> [1] https://patchwork.freedesktop.org/series/112188/
> 
> Matthew Brost (1):
>   Xe: Introduce initial tests for the new Intel Xe GPU driver.
> 
>  include/drm-uapi/xe_drm.h       |  786 +++++++++++++++
>  lib/drmtest.c                   |    3 +
>  lib/drmtest.h                   |    1 +
>  lib/meson.build                 |    4 +
>  lib/xe/xe_compute.c             |  327 +++++++
>  lib/xe/xe_compute.h             |   93 ++
>  lib/xe/xe_ioctl.c               |  441 +++++++++
>  lib/xe/xe_ioctl.h               |  107 +++
>  lib/xe/xe_query.c               |  267 ++++++
>  lib/xe/xe_query.h               |   76 ++
>  lib/xe/xe_spin.c                |  157 +++
>  lib/xe/xe_spin.h                |   66 ++

placing the library changes first...

>  meson.build                     |    8 +
>  tests/meson.build               |    1 +
>  tests/xe/meson.build            |   30 +
>  tests/xe/xe_compute.c           |  130 +++
>  tests/xe/xe_dma_buf_sync.c      |  226 +++++
>  tests/xe/xe_evict.c             |  619 ++++++++++++
>  tests/xe/xe_exec_balancer.c     |  620 ++++++++++++
>  tests/xe/xe_exec_basic.c        |  294 ++++++
>  tests/xe/xe_exec_compute_mode.c |  303 ++++++
>  tests/xe/xe_exec_fault_mode.c   |  471 +++++++++
>  tests/xe/xe_exec_reset.c        |  806 ++++++++++++++++
>  tests/xe/xe_exec_threads.c      | 1148 ++++++++++++++++++++++
>  tests/xe/xe_guc_pc.c            |  424 +++++++++
>  tests/xe/xe_huc_copy.c          |  187 ++++
>  tests/xe/xe_live_ktest.c        |   17 +
>  tests/xe/xe_mmap.c              |   57 ++
>  tests/xe/xe_pm.c                |  384 ++++++++
>  tests/xe/xe_prime_self_import.c |  462 +++++++++
>  tests/xe/xe_query.c             |  431 +++++++++
>  tests/xe/xe_vm.c                | 1577 +++++++++++++++++++++++++++++++
>  tests/xe/xe_waitfence.c         |   88 ++

And then the tests, broken per area. This way, developers more
experienced with some features (guc, mmap, vma, dma_buf, fences, ...) could
better review such changes.

Regards,
Mauro