public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation
Date: Wed, 11 Jan 2023 19:12:05 +0100	[thread overview]
Message-ID: <20230111181205.55997-4-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230111181205.55997-1-zbigniew.kempczynski@intel.com>

Fix the bug where lack of information about dependency object size
during spinner creation may lead to object overlapping and failing
with ENOSPC.

Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/7681

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 tests/kms_cursor_legacy.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index 6b75e98cb8..f1e55906a0 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -1471,7 +1471,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
 
 		spin = igt_spin_new(display->drm_fd,
 				    .ahnd = ahnd,
-				    .dependency = fb_info[1].gem_handle);
+				    .dependency = fb_info[1].gem_handle,
+				    .dependency_size = fb_info[1].size);
 
 		vblank_start = kmstest_get_vblank(display->drm_fd, pipe, DRM_VBLANK_NEXTONMISS);
 
-- 
2.34.1

  parent reply	other threads:[~2023-01-11 18:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 18:12 [igt-dev] [PATCH i-g-t 0/3] Fix kms_cursor_legacy ENOSPC issue Zbigniew Kempczyński
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 1/3] lib/intel_allocator: Fix alignment variable used in debug path Zbigniew Kempczyński
2023-01-12 12:17   ` Kamil Konieczny
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_dummyload: Don't assume dependency object size Zbigniew Kempczyński
2023-01-12 12:18   ` Kamil Konieczny
2023-01-11 18:12 ` Zbigniew Kempczyński [this message]
2023-01-12 13:07   ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation Kamil Konieczny
2023-01-12 13:23   ` Kamil Konieczny
2023-01-11 19:06 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_cursor_legacy ENOSPC issue Patchwork
2023-01-12  2:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230111181205.55997-4-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox