Re: [igt-dev] [PATCH i-g-t v4 3/8] lib/dsc: Add helpers for VDSC YCbCr420 debugfs entry

Hogander, Jouni
2023-01-20T11:02:20Z

On Wed, 2023-01-18 at 22:06 +0530, Swati Sharma wrote:
>
>
> On 13-Jan-23 1:47 PM, Hogander, Jouni wrote:
> > > + * Returns: 1 on success or negative error code, in case of
> > > failure.
> > 0 is usually success, < 0 is error. This is also in coding style
> > document. I see igt_force_dsc_enable is also using 1. Maybe you
> > should
> > fix that as well in a separate patch.
> >
> This ret value is returned from igt_sysfs_write() which returns the
> number of bytes written, or -errno on error.
>
> I guess we can't change this.
>

No, igt_sysfs_write is logical. It returns bytes written or < 0 on
error. What you could do is to check ret value of igt_sysfs_write and
return 0 if igt_sysfs_write succeeded.

BR,

Jouni Högander