Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Maíra Canal" <mcanal@igalia.com>
To: "Melissa Wen" <mwen@igalia.com>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Petri Latvala" <petri.latvala@intel.com>,
	"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Maxime Ripard" <maxime@cerno.tech>
Cc: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v5 4/4] tests/v3d_perfmon: Make sure v3d supports perfmon
Date: Thu, 12 Jan 2023 16:37:42 -0300	[thread overview]
Message-ID: <20230112193741.55630-5-mcanal@igalia.com> (raw)
In-Reply-To: <20230112193741.55630-1-mcanal@igalia.com>

Performance Monitors for the v3d were introduced in Linux 5.15, so a check
if v3d supports Performance Monitors is essential to assure that the tests
will perform correctly. Therefore, check if v3d has perfmon support before
running the tests.

Reviewed-by: Melissa Wen <mwen@igalia.com>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 tests/v3d/v3d_perfmon.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/v3d/v3d_perfmon.c b/tests/v3d/v3d_perfmon.c
index bf983dbf..3f55ddb1 100644
--- a/tests/v3d/v3d_perfmon.c
+++ b/tests/v3d/v3d_perfmon.c
@@ -12,8 +12,10 @@ igt_main
 {
 	int fd;
 
-	igt_fixture
+	igt_fixture {
 		fd = drm_open_driver(DRIVER_V3D);
+		igt_require(igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_PERFMON));
+	}
 
 	igt_describe("Make sure a perfmon cannot be created with zero counters.");
 	igt_subtest("create-perfmon-0") {
-- 
2.39.0

  parent reply	other threads:[~2023-01-12 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 19:37 [igt-dev] [PATCH i-g-t v5 0/4] Make sure v3d/vc4 support performance monitors Maíra Canal
2023-01-12 19:37 ` [igt-dev] [PATCH i-g-t v5 1/4] lib/igt_vc4: Rework igt_vc4_get_param() Maíra Canal
2023-01-26  8:59   ` Kamil Konieczny
2023-01-12 19:37 ` [igt-dev] [PATCH i-g-t v5 2/4] tests/vc4_perfmon: Make sure vc4 supports perfmon Maíra Canal
2023-01-12 19:37 ` [igt-dev] [PATCH i-g-t v5 3/4] lib/igt_v3d: Rework igt_v3d_get_param() Maíra Canal
2023-01-26  9:00   ` Kamil Konieczny
2023-01-12 19:37 ` Maíra Canal [this message]
2023-01-12 20:39 ` [igt-dev] ✓ Fi.CI.BAT: success for Make sure v3d/vc4 support performance monitors (rev4) Patchwork
2023-01-13 10:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230112193741.55630-5-mcanal@igalia.com \
    --to=mcanal@igalia.com \
    --cc=andrealmeid@igalia.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=maxime@cerno.tech \
    --cc=mwen@igalia.com \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox