public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/7] lib/i915_blt: Check for Tile-YF in fast_copy
Date: Wed, 18 Jan 2023 10:06:36 +0100	[thread overview]
Message-ID: <20230118090640.10659-4-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230118090640.10659-1-zbigniew.kempczynski@intel.com>

From: Karolina Stolarek <karolina.stolarek@intel.com>

In older gens Tile4 is not available, we have Tile-YF instead. Check for
both tilings when setting up the fast_copy command.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/i915/i915_blt.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index 1bb95b3129..ca02676d95 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -326,6 +326,11 @@ static enum blt_aux_mode __aux_mode(const struct blt_copy_object *obj)
 	return AM_AUX_NONE;
 }
 
+static bool __new_tile_y_type(enum blt_tiling_type tiling)
+{
+	return tiling == T_TILE4 || tiling == T_YFMAJOR;
+}
+
 static void fill_data(struct gen12_block_copy_data *data,
 		      const struct blt_copy_data *blt,
 		      uint64_t src_offset, uint64_t dst_offset,
@@ -1016,8 +1021,8 @@ uint64_t emit_blt_fast_copy(int i915,
 	data.dw01.color_depth = __fast_color_depth(blt->color_depth);
 	data.dw01.dst_memory = __memory_type(blt->dst.region);
 	data.dw01.src_memory = __memory_type(blt->src.region);
-	data.dw01.dst_type_y = blt->dst.tiling == T_TILE4 ? 1 : 0;
-	data.dw01.src_type_y = blt->src.tiling == T_TILE4 ? 1 : 0;
+	data.dw01.dst_type_y = __new_tile_y_type(blt->dst.tiling) ? 1 : 0;
+	data.dw01.src_type_y = __new_tile_y_type(blt->src.tiling) ? 1 : 0;
 
 	data.dw02.dst_x1 = blt->dst.x1;
 	data.dw02.dst_y1 = blt->dst.y1;
-- 
2.34.1

  parent reply	other threads:[~2023-01-18  9:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  9:06 [igt-dev] [PATCH i-g-t 0/7] Run gem_exercise_blt on all gens Zbigniew Kempczyński
2023-01-18  9:06 ` [igt-dev] [PATCH i-g-t 1/7] i915/lib: Add new library for blitter and tiling formats Zbigniew Kempczyński
2023-01-18  9:06 ` [igt-dev] [PATCH i-g-t 2/7] lib: Update platform definitions with blitter information Zbigniew Kempczyński
2023-01-18  9:06 ` Zbigniew Kempczyński [this message]
2023-01-18  9:06 ` [igt-dev] [PATCH i-g-t 4/7] lib/i915_blt: Add common functions for blt_copy_object Zbigniew Kempczyński
2023-01-18  9:06 ` [igt-dev] [PATCH i-g-t 5/7] tests/gem_exercise_blt: Add fast-copy test Zbigniew Kempczyński
2023-01-18  9:06 ` [igt-dev] [PATCH i-g-t 6/7] tests/gem_exercise_blt: Add fast-copy-emit test Zbigniew Kempczyński
2023-01-18  9:06 ` [igt-dev] [PATCH i-g-t 7/7] HAX: Run gem_exercise_blt on all gens to verify skip correctness Zbigniew Kempczyński
2023-01-18 12:39 ` [igt-dev] ✗ Fi.CI.BAT: failure for Run gem_exercise_blt on all gens Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230118090640.10659-4-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox