From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id D717A10E752 for ; Wed, 18 Jan 2023 13:42:14 +0000 (UTC) From: Nirmoy Das To: igt-dev@lists.freedesktop.org Date: Wed, 18 Jan 2023 14:42:05 +0100 Message-Id: <20230118134205.4156-1-nirmoy.das@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t] tests/gem_blits: Don't test Y Tile for newer GPUs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nirmoy Das Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Stanislav Lisovskiy Legacy Y Tile is no longer supported on newer GPUs. Cc: Zbigniew Kempczyński Co-developed-by: Nirmoy Das Signed-off-by: Nirmoy Das Signed-off-by: Stanislav Lisovskiy --- tests/i915/gem_blits.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/tests/i915/gem_blits.c b/tests/i915/gem_blits.c index d9296cf2d..577eb6bfc 100644 --- a/tests/i915/gem_blits.c +++ b/tests/i915/gem_blits.c @@ -793,6 +793,7 @@ igt_main igt_subtest("basic") { struct buffer *src, *dst; unsigned int x, y; + int devid = intel_get_drm_devid(device.fd); for (unsigned int height = 1; height <= 16; height <<= 2) { for (unsigned int y0 = ZERO; y0 <= (height > 2 ? BELOW : ZERO); y0++) { @@ -808,12 +809,28 @@ igt_main for (unsigned int src_tiling = I915_TILING_NONE; src_tiling <= (device.gen >= 6 ? I915_TILING_Y : I915_TILING_X); src_tiling++) { + + /* + * Legacy Y Tile is not supported on newer GPUs so skip that. + * Probably need more generic solution to detect and skip unsupported formats. + */ + if (intel_graphics_ver(devid) >= IP_VER(12, 60) && (src_tiling == I915_TILING_Y)) + continue; + buffer_set_tiling(&device, src, src_tiling); x = start_at(width, x0); for (unsigned int dst_tiling = I915_TILING_NONE; dst_tiling <= (device.gen >= 6 ? I915_TILING_Y : I915_TILING_X); dst_tiling++) { + + /* + * Legacy Y Tile is not supported on newer GPUs so skip that. + * Probably need more generic solution to detect and skip unsupported formats. + */ + if (intel_graphics_ver(devid) >= IP_VER(12, 60) && (dst_tiling == I915_TILING_Y)) + continue; + buffer_set_tiling(&device, dst, dst_tiling); for (enum mode down = CPU; down <= WC; down++) { -- 2.39.0