public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: matthew.auld@intel.com, Nirmoy Das <nirmoy.das@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/2] test/i915/gem_eio: Skip suspend test on smallbar machine
Date: Fri, 20 Jan 2023 11:07:50 +0100	[thread overview]
Message-ID: <20230120100750.24122-2-nirmoy.das@intel.com> (raw)
In-Reply-To: <20230120100750.24122-1-nirmoy.das@intel.com>

Suspending machine requires backing up gem objects to
system memory. CPU non-visible lmem objects can only be
backed up with the help of GPU on a smallbar device and if
the gpu is wedged then such backup action will fail with -EIO.

This test sets the gpu to wedge state before suspending the
machine which will always fail on smallbar machine.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/7896
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 tests/i915/gem_eio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
index 70e82b811..8dbaa7a75 100644
--- a/tests/i915/gem_eio.c
+++ b/tests/i915/gem_eio.c
@@ -500,6 +500,7 @@ static void test_wait(int fd, unsigned int flags, unsigned int wait)
 
 static void test_suspend(int fd, int state)
 {
+	igt_require(!gem_has_smallbar(fd));
 	/* Do a suspend first so that we don't skip inside the test */
 	igt_system_suspend_autoresume(state, SUSPEND_TEST_DEVICES);
 
-- 
2.39.0

  reply	other threads:[~2023-01-20 10:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 10:07 [igt-dev] [PATCH i-g-t 1/2] lib/i915/intel_memory_region: Add gem_has_smallbar Nirmoy Das
2023-01-20 10:07 ` Nirmoy Das [this message]
2023-01-20 15:45   ` [igt-dev] [PATCH i-g-t 2/2] test/i915/gem_eio: Skip suspend test on smallbar machine Matthew Auld
2023-01-20 19:38     ` Das, Nirmoy
2023-01-20 10:14 ` [igt-dev] [PATCH i-g-t 1/2] lib/i915/intel_memory_region: Add gem_has_smallbar Das, Nirmoy
2023-01-20 11:30 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] " Patchwork
2023-01-23 11:56 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/i915/intel_memory_region: Add gem_has_smallbar (rev2) Patchwork
2023-01-23 15:16 ` [igt-dev] [PATCH i-g-t 1/2] lib/i915/intel_memory_region: Add gem_has_smallbar Andrzej Hajda
2023-01-23 15:45   ` Das, Nirmoy
2023-01-23 19:53     ` Andrzej Hajda
2023-01-24  8:01       ` Das, Nirmoy
2023-01-24  1:23 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib/i915/intel_memory_region: Add gem_has_smallbar (rev2) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-01-23 10:54 [igt-dev] [PATCH i-g-t v2 1/2] lib/i915/intel_memory_region: Add gem_has_smallbar Nirmoy Das
2023-01-23 10:54 ` [igt-dev] [PATCH i-g-t 2/2] test/i915/gem_eio: Skip suspend test on smallbar machine Nirmoy Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230120100750.24122-2-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox