Re: [igt-dev] [PATCH i-g-t 5/5] lib/igt_fb: add missing include in header

Swati Sharma
2023-01-21T05:28:34Z

Thanks for the patch Kamil!
https://patchwork.freedesktop.org/series/113170/ gitlab pipeline is
success now.

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 20-Jan-23 11:42 PM, Kamil Konieczny wrote:
> Hi,
>
> On 2023-01-20 at 23:11:19 +0530, Swati Sharma wrote:
>> From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>>
>> Direct include of lib igt_fb header breaks builds with errors
>>
>> xf86drmMode.h:533:2: error: unknown type name ‘uint32_t’
>>
>> Fixed it with adding proper include in heade
>
> This one should be first in series, not last one.

I can re-float if required.

>
> Petri: there is also no [igt-dev] in subject ?
>
> Regards,
> Kamil
>
>>
>> Cc: Swati Sharma <swati2.sharma@intel.com>
>> Cc: Petri Latvala <petri.latvala@intel.com>
>> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>> ---
>> lib/igt_fb.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/igt_fb.h b/lib/igt_fb.h
>> index 6995b14b..73bdfc86 100644
>> --- a/lib/igt_fb.h
>> +++ b/lib/igt_fb.h
>> @@ -32,6 +32,7 @@
>> #include <cairo.h>
>> #include <stddef.h>
>> #include <stdbool.h>
>> +#include <stdint.h>
>> #include <drm_fourcc.h>
>> #include <xf86drmMode.h>
>>
>> --
>> 2.25.1
>>

--
~Swati Sharma