[igt-dev] [PATCH i-g-t 1/4] tools/intel_reg: Simplify negative ports

Ville Syrjala
2023-01-25T05:42:42Z

Let's avoid having to type in the explicit negative value for
all the port enums.

v2: Copy-paste the comment from intel_reg.c (Jani)

Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tools/intel_reg_spec.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/intel_reg_spec.h b/tools/intel_reg_spec.h
index c94c61bab3f8..1a2c5ebd9a58 100644
--- a/tools/intel_reg_spec.h
+++ b/tools/intel_reg_spec.h
@@ -25,10 +25,12 @@
#define __INTEL_REG_SPEC_H__

enum port_addr {
+ /* Negative port numbers are not real sideband ports. */
+ PORT_MMIO = -127,
+ PORT_PORTIO_VGA, /* see vga reg read/write */
+ PORT_MMIO_VGA, /* see vga reg read/write */
+
PORT_NONE = 0,
- PORT_MMIO = -1,
- PORT_PORTIO_VGA = -2, /* see vga reg read/write */
- PORT_MMIO_VGA = -3, /* see vga reg read/write */

/* vlv */
PORT_BUNIT = 0x03,
--
2.39.1