From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF1A610E2BF for ; Thu, 26 Jan 2023 10:57:19 +0000 (UTC) From: Petri Latvala To: igt-dev@lists.freedesktop.org Date: Thu, 26 Jan 2023 12:53:35 +0200 Message-Id: <20230126105338.419418-1-petri.latvala@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t 0/3] runner: Using 'abort' as test result instead of a separate test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petri Latvala Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: If a test caused an abort condition to trigger, a pseudoresult "igt@runner@aborted" would be generated, detailing which test caused the condition. That was implemented in a simpler world where there were no dynamic subtests and CI systems (i915-CI in particular) didn't have much test resuming happening. The generated pseudoresult was completely unable to point to a particular dynamic subtest if the executed subtest had any, and there could inherently be only one of them. When combined with the fact that the pseudoresult doesn't have logs that could be used to automatically point to particular bug reports, that made results filtering by CIBugLog difficult. With socket communications it's easier to inject information "in between" test's logs and result overriding is designed into the system. Thus, when using socket communications, this patch series will make the abort-condition-causing test's result 'abort' instead of using that pseudoresult. The flow becomes a little bit messier with monitor_output() gaining more and more out-parameters but those can be cleaned later. Petri Latvala (3): runner: Don't override more results than requested runner: Refactor abort-checking to a helper function runner: Use 'abort' as result if a test caused an abort runner/executor.c | 121 +++++++++++++++++++++++++++++++++++++++------ runner/resultgen.c | 6 +++ 2 files changed, 111 insertions(+), 16 deletions(-) -- 2.30.2