From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/2] i915/i915_power: Sanity check power measurement
Date: Fri, 27 Jan 2023 10:09:33 -0800 [thread overview]
Message-ID: <20230127180934.158123-2-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230127180934.158123-1-ashutosh.dixit@intel.com>
Add a test to sanity check power measurement on integrated/discrete by
requiring power under load to be > 0 and >= idle power.
v2: Code reorganization (Kamil K)
v3: More code reorganization (Kamil K)
v4: Make sleep duration uint32_t and use #define (Kamil K)
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
tests/i915/i915_power.c | 72 +++++++++++++++++++++++++++++++++++++++++
tests/meson.build | 1 +
2 files changed, 73 insertions(+)
create mode 100644 tests/i915/i915_power.c
diff --git a/tests/i915/i915_power.c b/tests/i915/i915_power.c
new file mode 100644
index 00000000000..f2fd228698a
--- /dev/null
+++ b/tests/i915/i915_power.c
@@ -0,0 +1,72 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#include "igt.h"
+#include "i915/gem.h"
+#include "igt_power.h"
+
+IGT_TEST_DESCRIPTION("i915 power measurement tests");
+
+static double measure_power(struct igt_power *pwr, uint32_t duration_sec)
+{
+ struct power_sample sample[2];
+
+ igt_power_get_energy(pwr, &sample[0]);
+ usleep(duration_sec * USEC_PER_SEC);
+ igt_power_get_energy(pwr, &sample[1]);
+
+ return igt_power_get_mW(pwr, &sample[0], &sample[1]);
+}
+
+static void sanity(int i915)
+{
+ const intel_ctx_t *ctx;
+ struct igt_power pwr;
+ double idle, busy;
+ igt_spin_t *spin;
+ uint64_t ahnd;
+
+#define DURATION_SEC 2
+
+ /* Idle power */
+ igt_require(!igt_power_open(i915, &pwr, "gpu"));
+ gem_quiescent_gpu(i915);
+ idle = measure_power(&pwr, DURATION_SEC);
+
+ /* Busy power */
+ ctx = intel_ctx_create_all_physical(i915);
+ ahnd = get_reloc_ahnd(i915, ctx->id);
+ spin = igt_spin_new(i915, .ahnd = ahnd, .ctx = ctx,
+ .engine = ALL_ENGINES,
+ .flags = IGT_SPIN_POLL_RUN);
+ /* Wait till at least one spinner starts */
+ igt_spin_busywait_until_started(spin);
+ busy = measure_power(&pwr, DURATION_SEC);
+ igt_free_spins(i915);
+ put_ahnd(ahnd);
+ intel_ctx_destroy(i915, ctx);
+ igt_power_close(&pwr);
+
+ igt_info("Measured power: idle: %g mW, busy: %g mW\n", idle, busy);
+ igt_assert(idle >= 0 && busy > 0 && busy > idle);
+}
+
+igt_main
+{
+ int i915;
+
+ igt_fixture {
+ i915 = drm_open_driver_master(DRIVER_INTEL);
+ }
+
+ igt_describe("Sanity check gpu power measurement");
+ igt_subtest("sanity") {
+ sanity(i915);
+ }
+
+ igt_fixture {
+ close(i915);
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index cce9d89e1c8..d93a07c9ed6 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -213,6 +213,7 @@ i915_progs = [
'i915_pm_dc',
'i915_pm_rps',
'i915_pm_sseu',
+ 'i915_power',
'i915_query',
'i915_selftest',
'i915_suspend',
--
2.38.0
next prev parent reply other threads:[~2023-01-27 18:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 18:09 [igt-dev] [PATCH i-g-t 0/2] i915/i915_power: Sanity check power measurement Ashutosh Dixit
2023-01-27 18:09 ` Ashutosh Dixit [this message]
2023-01-27 18:09 ` [igt-dev] [PATCH i-g-t 2/2] HAX: Add i915_power@sanity to fast-feedback.testlist Ashutosh Dixit
2023-01-27 19:14 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/i915_power: Sanity check power measurement Patchwork
2023-01-27 23:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-01-27 16:08 [igt-dev] [PATCH i-g-t 0/2] " Ashutosh Dixit
2023-01-27 16:08 ` [igt-dev] [PATCH i-g-t 1/2] " Ashutosh Dixit
2023-01-27 16:46 ` Kamil Konieczny
2023-01-27 16:55 ` Dixit, Ashutosh
2023-01-27 17:44 ` Kamil Konieczny
2023-01-27 18:12 ` Dixit, Ashutosh
2023-01-27 6:25 [igt-dev] [PATCH i-g-t 0/2] " Ashutosh Dixit
2023-01-27 6:25 ` [igt-dev] [PATCH i-g-t 1/2] " Ashutosh Dixit
2023-01-27 12:29 ` Kamil Konieczny
2023-01-27 16:13 ` Dixit, Ashutosh
2023-01-21 5:41 [igt-dev] [PATCH i-g-t 0/2] " Ashutosh Dixit
2023-01-21 5:41 ` [igt-dev] [PATCH i-g-t 1/2] " Ashutosh Dixit
2023-01-24 12:59 ` Tauro, Riana
2023-01-24 17:00 ` Kamil Konieczny
2023-01-24 18:01 ` Dixit, Ashutosh
2023-01-25 9:40 ` Kamil Konieczny
2023-01-27 6:28 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127180934.158123-2-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox