From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFA1D10E1B7 for ; Thu, 2 Feb 2023 07:19:10 +0000 (UTC) From: Swati Sharma To: igt-dev@lists.freedesktop.org Date: Thu, 2 Feb 2023 12:51:16 +0530 Message-Id: <20230202072121.26153-2-swati2.sharma@intel.com> In-Reply-To: <20230202072121.26153-1-swati2.sharma@intel.com> References: <20230202072121.26153-1-swati2.sharma@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v2 1/6] lib/dsc: Fix return value List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: 0 is usually success, < 0 is error. Fix that. Signed-off-by: Swati Sharma --- lib/igt_dsc.c | 7 +++++-- tests/i915/kms_dsc_helper.c | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/igt_dsc.c b/lib/igt_dsc.c index 25dcb5840..64dd6b29a 100644 --- a/lib/igt_dsc.c +++ b/lib/igt_dsc.c @@ -35,6 +35,9 @@ static int write_dsc_debugfs(int drmfd, char *connector_name, const char *file_n close(debugfs_fd); + if (ret > 0) + return 0; + return ret; } @@ -92,7 +95,7 @@ bool igt_is_force_dsc_enabled(int drmfd, char *connector_name) * @drmfd: A drm file descriptor * @connector_name: Name of the libdrm connector we're going to use * - * Returns: 1 on success or negative error code, in case of failure. + * Returns: 0 on success or negative error code, in case of failure. */ int igt_force_dsc_enable(int drmfd, char *connector_name) { @@ -105,7 +108,7 @@ int igt_force_dsc_enable(int drmfd, char *connector_name) * @connector_name: Name of the libdrm connector we're going to use * @bpc: Input BPC * - * Returns: No. of bytes written or negative error code, in case of failure. + * Returns: 0 on success or negative error code, in case of failure. */ int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc) { diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c index a80f3d787..e2c278c7a 100644 --- a/tests/i915/kms_dsc_helper.c +++ b/tests/i915/kms_dsc_helper.c @@ -14,7 +14,7 @@ void force_dsc_enable(int drmfd, igt_output_t *output) igt_debug("Forcing DSC enable on %s\n", output->name); ret = igt_force_dsc_enable(drmfd, output->name); - igt_assert_f(ret > 0, "forcing dsc enable debugfs_write failed\n"); + igt_assert_f(ret == 0, "forcing dsc enable debugfs_write failed\n"); } void force_dsc_enable_bpc(int drmfd, igt_output_t *output, int input_bpc) @@ -24,7 +24,7 @@ void force_dsc_enable_bpc(int drmfd, igt_output_t *output, int input_bpc) igt_debug("Forcing input DSC BPC to %d on %s\n", input_bpc, output->name); ret = igt_force_dsc_enable_bpc(drmfd, output->name, input_bpc); - igt_assert_f(ret > 0, "forcing input dsc bpc debugfs_write failed\n"); + igt_assert_f(ret == 0, "forcing input dsc bpc debugfs_write failed\n"); } void save_force_dsc_en(int drmfd, igt_output_t *output) -- 2.25.1