Re: [igt-dev] [PATCH i-g-t 0/3] V3D Mixed Job Submission Tests

[Melissa Wen <mwen@igalia.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1954 bytes --]

On 01/13, Maíra Canal wrote:
> Currently, the V3D tests only support CL job submissions [1], while V3D has also
> capabilities for CSD and TFU jobs. Therefore, create tests for
> DRM_IOCTL_V3D_SUBMIT_CSD, an ioctl for dispatching compute shader jobs to the
> GPU. In order to create a simple CSD job, I hard-coded the pipeline assembly
> shader of an empty shader in order to reproduce a shader and be able to create
> an acceptable packet that can be sent to the GPU.
> 
> So, patch 1 introduces a helper function to submit a minimal CSD job to the GPU,
> which will be useful for the tests. The minimal job will use the pipeline
> assembly shader of an empty shader. Patches 2-3 will include new tests in the
> V3D test suite for DRM_IOCTL_V3D_SUBMIT_CSD and create tests that mix different
> types of jobs, in order to evaluate the synchronization between the two types of
> jobs. 
> 
> [1] This series depends on https://patchwork.freedesktop.org/series/112363/

Hi Maíra,

Thanks for the extensive testing.
I just commented about a minor improvement for threaded-submission test.
With this in the next version, you can add:

Reviewed-by: Melissa Wen <mwen@igalia.com>

Thanks,

Melissa
> 
> Best Regards,
> - Maíra Canal
> 
> Maíra Canal (3):
>   lib/v3d: Add a helper to create a empty shader
>   tests/v3d_submit_csd: Create test for V3D's Submit CSD IOCTL
>   tests/v3d_job_submission: Create tests to mix CL and CSD jobs
> 
>  lib/igt_v3d.c                  |  60 ++++++
>  lib/igt_v3d.h                  |  20 ++
>  tests/v3d/meson.build          |   2 +
>  tests/v3d/v3d_job_submission.c | 212 ++++++++++++++++++++
>  tests/v3d/v3d_submit_csd.c     | 357 +++++++++++++++++++++++++++++++++
>  tests/v3d_ci/v3d.testlist      |  21 ++
>  6 files changed, 672 insertions(+)
>  create mode 100644 tests/v3d/v3d_job_submission.c
>  create mode 100644 tests/v3d/v3d_submit_csd.c
> 
> -- 
> 2.39.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]