From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, karthik.b.s@intel.com
Subject: [igt-dev] [i-g-t 1/2] tests/kms_cursor_edge_walk: Re-org dynamic subtests
Date: Fri, 10 Feb 2023 09:54:18 +0530 [thread overview]
Message-ID: <20230210042419.1744563-1-bhanuprakash.modem@intel.com> (raw)
Instead of clubbing all dynamic subtests, let's have an individual
subtest for each size & type.
Fixes: 54ff3199b (tests/kms_cursor_edge_walk: Convert tests to dynamic)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_cursor_edge_walk.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/tests/kms_cursor_edge_walk.c b/tests/kms_cursor_edge_walk.c
index e653b9ab9..96812776c 100644
--- a/tests/kms_cursor_edge_walk.c
+++ b/tests/kms_cursor_edge_walk.c
@@ -342,21 +342,21 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
igt_display_require_output(&data.display);
}
- igt_describe("Checking cursor by walking left/right/top/bottom edge of screen");
- igt_subtest_group {
- for (i = 0; i < ARRAY_SIZE(tests); i++) {
- igt_subtest_with_dynamic(tests[i].name) {
+ for (i = 0; i < ARRAY_SIZE(tests); i++) {
+ for (data.curw = 64; data.curw <= 256; data.curw *= 2) {
+ data.curh = data.curw;
+ igt_fixture
+ igt_require(data.curw <= max_curw && data.curh <= max_curh);
+
+ igt_describe_f("Checking cursor size %dx%d by walking %s of screen",
+ data.curw, data.curh, tests[i].name);
+ igt_subtest_with_dynamic_f("%dx%d-%s", data.curw,
+ data.curh, tests[i].name) {
for_each_pipe_with_single_output(&data.display, data.pipe, data.output) {
- for (data.curw = 64; data.curw <= 256; data.curw *= 2) {
- data.curh = data.curw;
- igt_require(data.curw <= max_curw && data.curh <= max_curh);
-
- igt_dynamic_f("pipe-%s-%s-%dx%d",
- kmstest_pipe_name(data.pipe),
- data.output->name,
- data.curw, data.curh)
- test_crtc(&data, tests[i].flags);
- }
+ igt_dynamic_f("pipe-%s-%s",
+ kmstest_pipe_name(data.pipe),
+ data.output->name)
+ test_crtc(&data, tests[i].flags);
}
}
}
--
2.39.0
next reply other threads:[~2023-02-10 4:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 4:24 Bhanuprakash Modem [this message]
2023-02-10 4:24 ` [igt-dev] [i-g-t 2/2] tests/kms_cursor_edge_walk: Limit the execution to two pipes Bhanuprakash Modem
2023-02-10 8:18 ` Karthik B S
2023-02-10 8:10 ` [igt-dev] [i-g-t 1/2] tests/kms_cursor_edge_walk: Re-org dynamic subtests Karthik B S
2023-02-10 15:22 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2023-02-10 22:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210042419.1744563-1-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox