From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/1] runner/job_list: return error on crashes while running --list-subtests
Date: Mon, 20 Feb 2023 10:20:05 +0100 [thread overview]
Message-ID: <20230220092005.890959-2-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20230220092005.890959-1-mauro.chehab@linux.intel.com>
From: Mauro Carvalho Chehab <mchehab@kernel.org>
Changes on tests may break --list-subtests, if they, for instance,
someone adds a code outside igt_subtests that depends on igt_fixture
to run, causing:
Received signal SIGABRT.
Stack trace:
#0 [fatal_sig_handler+0x17b]
#1 [__sigaction+0x50]
#2 [__pthread_kill_implementation+0x10c]
#3 [gsignal+0x16]
#4 [abort+0xd7]
#5 [__assert_fail_base.cold+0xf]
#6 [__assert_fail+0x46]
#7 [internal_assert+0xe5]
#8 [igt_fail+0xea]
#9 [__igt_fail_assert+0x10e]
#10 [xe_number_hw_engines+0x6b]
#11 [__igt_unique____real_main1528+0x1ac0]
#12 [main+0x23]
#13 [__libc_start_call_main+0x80]
#14 [__libc_start_main+0x89]
#15 [_start+0x25]
Aborted (core dumped)
IGT runner currently prints the message, but don't ignore the
error. That prevents scripts to rely on the IGT testlist
output, as the list will miss subtests.
So, instead, return an error.
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
runner/job_list.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/runner/job_list.c b/runner/job_list.c
index a259b9531a58..e6ea836310fd 100644
--- a/runner/job_list.c
+++ b/runner/job_list.c
@@ -130,6 +130,7 @@ static void add_subtests(struct job_list *job_list, struct settings *settings,
}
} else {
fprintf(stderr, "Test binary %s died unexpectedly\n", binary);
+ exit(1);
}
}
--
2.39.0
prev parent reply other threads:[~2023-02-20 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 9:20 [igt-dev] [PATCH i-g-t 0/1] Fix IGT runner error logic when listing subtests Mauro Carvalho Chehab
2023-02-20 9:20 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220092005.890959-2-mauro.chehab@linux.intel.com \
--to=mauro.chehab@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox