Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 7/7] runner/job_list: return error on crashes while running --list-subtests
Date: Tue, 21 Feb 2023 12:46:21 +0100	[thread overview]
Message-ID: <20230221114621.32785-8-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230221114621.32785-1-zbigniew.kempczynski@intel.com>

Changes on tests may break --list-subtests, if they, for instance,
someone adds a code outside igt_subtests that depends on igt_fixture
to run, causing:

        Received signal SIGABRT.
        Stack trace:
         #0 [fatal_sig_handler+0x17b]
         #1 [__sigaction+0x50]
         #2 [__pthread_kill_implementation+0x10c]
         #3 [gsignal+0x16]
         #4 [abort+0xd7]
         #5 [__assert_fail_base.cold+0xf]
         #6 [__assert_fail+0x46]
         #7 [internal_assert+0xe5]
         #8 [igt_fail+0xea]
         #9 [__igt_fail_assert+0x10e]
         #10 [xe_number_hw_engines+0x6b]
         #11 [__igt_unique____real_main1528+0x1ac0]
         #12 [main+0x23]
         #13 [__libc_start_call_main+0x80]
         #14 [__libc_start_main+0x89]
         #15 [_start+0x25]
        Aborted (core dumped)

IGT runner currently prints the message, but don't ignore the
error. That prevents scripts to rely on the IGT testlist
output, as the list will miss subtests.

So, instead, return an error.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 runner/job_list.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/runner/job_list.c b/runner/job_list.c
index a259b953..e6ea8363 100644
--- a/runner/job_list.c
+++ b/runner/job_list.c
@@ -130,6 +130,7 @@ static void add_subtests(struct job_list *job_list, struct settings *settings,
 		}
 	} else {
 		fprintf(stderr, "Test binary %s died unexpectedly\n", binary);
+		exit(1);
 	}
 }
 
-- 
2.34.1

  parent reply	other threads:[~2023-02-21 11:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 11:46 [igt-dev] [RFC PATCH i-g-t 0/7] Initial Xe test suite Zbigniew Kempczyński
2023-02-21 11:46 ` [igt-dev] [PATCH i-g-t 1/7] lib/xe: Introduce Xe library Zbigniew Kempczyński
2023-02-22 16:35   ` Kamil Konieczny
2023-02-22 20:46     ` Zbigniew Kempczyński
2023-02-24  7:22     ` Zbigniew Kempczyński
2023-02-22 21:03   ` Kamil Konieczny
2023-02-24 10:08     ` Zbigniew Kempczyński
2023-02-23  7:11   ` Mauro Carvalho Chehab
2023-02-24  6:48     ` Zbigniew Kempczyński
2023-02-21 11:46 ` [igt-dev] [PATCH i-g-t 2/7] drm-uapi/xe_drm: Add Xe uAPI Zbigniew Kempczyński
2023-02-21 13:36   ` Petri Latvala
2023-02-21 14:52     ` Zbigniew Kempczyński
2023-02-22 14:32   ` Kamil Konieczny
2023-02-22 15:22     ` Zbigniew Kempczyński
2023-03-16 14:23   ` Tvrtko Ursulin
2023-03-16 17:38     ` Zbigniew Kempczyński
2023-02-21 11:46 ` [igt-dev] [PATCH i-g-t 3/7] tests/xe: Add Xe IGT tests Zbigniew Kempczyński
2023-02-23 11:18   ` Mauro Carvalho Chehab
2023-02-21 11:46 ` [igt-dev] [PATCH i-g-t 4/7] tools/xe_reg: Add Xe register read/write tool Zbigniew Kempczyński
2023-02-23 11:19   ` Mauro Carvalho Chehab
2023-02-21 11:46 ` [igt-dev] [PATCH i-g-t 5/7] intel-ci/xe-fast-feedback: Introduce xe-fast-feedback list Zbigniew Kempczyński
2023-02-23 11:20   ` Mauro Carvalho Chehab
2023-02-23 14:00   ` Petri Latvala
2023-02-21 11:46 ` [igt-dev] [PATCH i-g-t 6/7] docs/testplan: Introduce new way for documenting IGT Zbigniew Kempczyński
2023-02-21 11:46 ` Zbigniew Kempczyński [this message]
2023-02-21 12:04 ` [igt-dev] ✗ GitLab.Pipeline: warning for Initial Xe test suite (rev2) Patchwork
2023-02-21 13:35 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221114621.32785-8-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox