From: pallavi.mishra@intel.com
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH 2/2] [PATCH i-g-t] i915/sysfs_timeslice_duration: Update test to work with GuC submission
Date: Fri, 24 Feb 2023 20:09:41 +0000 [thread overview]
Message-ID: <20230224200941.9867-2-pallavi.mishra@intel.com> (raw)
In-Reply-To: <20230224200941.9867-1-pallavi.mishra@intel.com>
From: Pallavi Mishra <pallavi.mishra@intel.com>
Increase reset timeout as resets can take a bit longer with GuC
submission because an error capture is done and with a large GuC log (16
MB) these take a while.
Don't run 'off' section as with GuC submission we don't handle
dynamically changing the timeslice duration from 'off' to 'on' on a
currently running context. This is not bug in GuC submission rather an
architectural decision to not implement this as there is no user aside
from IGTs.
Co-authored-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
---
tests/i915/sysfs_timeslice_duration.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/i915/sysfs_timeslice_duration.c b/tests/i915/sysfs_timeslice_duration.c
index 95dc3777..e4bf3ca7 100644
--- a/tests/i915/sysfs_timeslice_duration.c
+++ b/tests/i915/sysfs_timeslice_duration.c
@@ -29,6 +29,7 @@
#include <sys/types.h>
#include <unistd.h>
+#include "igt.h"
#include "igt_params.h"
#include "drmtest.h"
#include "i915/gem.h"
@@ -44,7 +45,7 @@
#include "sw_sync.h"
#define ATTR "timeslice_duration_ms"
-#define RESET_TIMEOUT 50 /* milliseconds, at least one jiffie for kworker */
+#define RESET_TIMEOUT 1000 /* milliseconds, at long enough for a error capture */
#define MI_SEMAPHORE_WAIT (0x1c << 23)
#define MI_SEMAPHORE_POLL (1 << 15)
@@ -484,6 +485,9 @@ static void test_off(int i915, int engine)
gem_quiescent_gpu(i915);
igt_require(enable_hangcheck(i915, false));
+ /* Not a supported behavior for GuC enabled platforms */
+ igt_require(!gem_using_guc_submission(i915));
+
igt_assert(igt_sysfs_scanf(engine, "class", "%u", &class) == 1);
igt_assert(igt_sysfs_scanf(engine, "instance", "%u", &inst) == 1);
--
2.34.1
next prev parent reply other threads:[~2023-02-24 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 20:09 [igt-dev] [PATCH 1/2] [PATCH i-g-t] i915/sysfs_heartbeat_interval: Update test to work with GuC submission pallavi.mishra
2023-02-24 20:09 ` pallavi.mishra [this message]
2023-03-13 17:35 ` [igt-dev] [PATCH 2/2] [PATCH i-g-t] i915/sysfs_timeslice_duration: " Kamil Konieczny
2023-03-08 13:07 ` [igt-dev] [PATCH 1/2] [PATCH i-g-t] i915/sysfs_heartbeat_interval: " Kamil Konieczny
2023-03-08 13:53 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [1/2,i-g-t] " Patchwork
2023-03-08 16:07 ` Kamil Konieczny
2023-03-09 5:21 ` Yedireswarapu, SaiX Nandan
2023-03-09 5:19 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-03-10 19:05 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-03-13 17:49 ` [igt-dev] [PATCH 1/2] [PATCH i-g-t] " Kamil Konieczny
-- strict thread matches above, loose matches on Subject: below --
2023-02-27 18:52 pallavi.mishra
2023-02-27 18:52 ` [igt-dev] [PATCH 2/2] [PATCH i-g-t] i915/sysfs_timeslice_duration: " pallavi.mishra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224200941.9867-2-pallavi.mishra@intel.com \
--to=pallavi.mishra@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox