Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/2] runner/resume: change exit code for results gen fail
Date: Tue, 28 Feb 2023 22:25:38 +0100	[thread overview]
Message-ID: <20230228212538.47984-2-kamil.konieczny@linux.intel.com> (raw)
In-Reply-To: <20230228212538.47984-1-kamil.konieczny@linux.intel.com>

When results generation fails exit with code 3, it will help
to differentiate from failed exection at resume runs. Added
also some debug messages at different error points.

Cc: Petri Latvala <adrinael@adrinael.net>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 runner/resume.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/runner/resume.c b/runner/resume.c
index eb8074e3..0f4e42bf 100644
--- a/runner/resume.c
+++ b/runner/resume.c
@@ -31,10 +31,13 @@ int main(int argc, char **argv)
 		return 127;
 	}
 
-	if (!initialize_execute_state_from_resume(dirfd, &state, &settings, &job_list))
+	if (!initialize_execute_state_from_resume(dirfd, &state, &settings, &job_list)) {
+		fprintf(stderr, "resume failed at initialization step\n");
 		return 127;
+	}
 
 	if (!execute(&state, &settings, &job_list)) {
+		fprintf(stderr, "resume failed at execute step\n");
 		exitcode = 1;
 	}
 
@@ -43,11 +46,13 @@ int main(int argc, char **argv)
 		 * Overall timeout happened. Results generation can
 		 * override this
 		 */
+		fprintf(stderr, "resume failed at timeout\n");
 		exitcode = 2;
 	}
 
 	if (!generate_results_path(settings.results_path)) {
-		exitcode = 1;
+		fprintf(stderr, "resume failed at generating results\n");
+		exitcode = 3;
 	}
 
 	printf("Done.\n");
-- 
2.37.2

  reply	other threads:[~2023-02-28 21:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 21:25 [igt-dev] [PATCH i-g-t 1/2] runner/resultgen: relax results processing Kamil Konieczny
2023-02-28 21:25 ` Kamil Konieczny [this message]
2023-03-01 13:24   ` [igt-dev] [PATCH i-g-t 2/2] runner/resume: change exit code for results gen fail Petri Latvala
2023-02-28 22:20 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] runner/resultgen: relax results processing Patchwork
2023-03-01  0:34 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-03-01 13:25 ` [igt-dev] [PATCH i-g-t 1/2] " Petri Latvala
2023-03-01 15:54   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230228212538.47984-2-kamil.konieczny@linux.intel.com \
    --to=kamil.konieczny@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox