From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id B95CB10E66A for ; Tue, 7 Mar 2023 21:18:48 +0000 (UTC) From: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= To: igt-dev@lists.freedesktop.org Date: Tue, 7 Mar 2023 22:18:18 +0100 Message-Id: <20230307211818.910093-8-zbigniew.kempczynski@intel.com> In-Reply-To: <20230307211818.910093-1-zbigniew.kempczynski@intel.com> References: <20230307211818.910093-1-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v6 7/7] runner/job_list: return error on crashes while running --list-subtests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Changes on tests may break --list-subtests, if they, for instance, someone adds a code outside igt_subtests that depends on igt_fixture to run, causing: Received signal SIGABRT. Stack trace: #0 [fatal_sig_handler+0x17b] #1 [__sigaction+0x50] #2 [__pthread_kill_implementation+0x10c] #3 [gsignal+0x16] #4 [abort+0xd7] #5 [__assert_fail_base.cold+0xf] #6 [__assert_fail+0x46] #7 [internal_assert+0xe5] #8 [igt_fail+0xea] #9 [__igt_fail_assert+0x10e] #10 [xe_number_hw_engines+0x6b] #11 [__igt_unique____real_main1528+0x1ac0] #12 [main+0x23] #13 [__libc_start_call_main+0x80] #14 [__libc_start_main+0x89] #15 [_start+0x25] Aborted (core dumped) IGT runner currently prints the message, but don't ignore the error. That prevents scripts to rely on the IGT testlist output, as the list will miss subtests. So, instead, return an error. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Zbigniew Kempczyński Reviewed-by: Mauro Carvalho Chehab --- runner/job_list.c | 1 + 1 file changed, 1 insertion(+) diff --git a/runner/job_list.c b/runner/job_list.c index a259b9531a..e6ea836310 100644 --- a/runner/job_list.c +++ b/runner/job_list.c @@ -130,6 +130,7 @@ static void add_subtests(struct job_list *job_list, struct settings *settings, } } else { fprintf(stderr, "Test binary %s died unexpectedly\n", binary); + exit(1); } } -- 2.34.1