From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/6] scripts/igt_doc.py: move show_subtests logic to the class
Date: Tue, 14 Mar 2023 12:41:23 +0100 [thread overview]
Message-ID: <20230314114127.649447-3-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20230314114127.649447-1-mauro.chehab@linux.intel.com>
From: Mauro Carvalho Chehab <mchehab@kernel.org>
Simplify the main code and avoid warnings about global vars with
pylint by moving its code to a separate function.
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
scripts/igt_doc.py | 34 ++++++++++++++++++++--------------
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/scripts/igt_doc.py b/scripts/igt_doc.py
index 67ab7984dd11..cc2768ae0847 100755
--- a/scripts/igt_doc.py
+++ b/scripts/igt_doc.py
@@ -1018,6 +1018,25 @@ class TestList:
sys.exit(f"{fname}:{file_ln + 1}: Error: unrecognized line. Need to add field at %s?\n\t==> %s" %
(self.config_fname, file_line))
+ def show_subtests(self, sort_field, filter_field):
+
+ """Show subtests, allowing sort and filter a field """
+
+ if sort_field:
+ test_subtests = tests.get_subtests(sort_field, filter_field)
+ for val_key in sorted(test_subtests.keys()):
+ if not test_subtests[val_key]:
+ continue
+ if val_key == "":
+ print("not defined:")
+ else:
+ print(f"{val_key}:")
+ for sub in test_subtests[val_key]:
+ print (f" {sub}")
+ else:
+ for sub in tests.get_subtests(sort_field, filter_field)[""]:
+ print (sub)
+
#
# Main
#
@@ -1056,20 +1075,7 @@ tests = TestList(parse_args.config, parse_args.include_plan, parse_args.files)
RUN = 0
if parse_args.show_subtests:
RUN = 1
- if parse_args.sort_field:
- test_subtests = tests.get_subtests(parse_args.sort_field, parse_args.filter_field)
- for val_key in sorted(test_subtests.keys()):
- if not test_subtests[val_key]:
- continue
- if val_key == "":
- print("not defined:")
- else:
- print(f"{val_key}:")
- for sub in test_subtests[val_key]:
- print (f" {sub}")
- else:
- for sub in tests.get_subtests(parse_args.sort_field, parse_args.filter_field)[""]:
- print (sub)
+ tests.show_subtests(parse_args.sort_field, parse_args.filter_field)
if parse_args.check_testlist:
RUN = 1
--
2.39.2
next prev parent reply other threads:[~2023-03-14 11:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:41 [igt-dev] [PATCH i-g-t 0/6] Do some improvements at igt_doc.py Mauro Carvalho Chehab
2023-03-14 11:41 ` [igt-dev] [PATCH i-g-t 1/6] xe_test_config.json: do some adjustments at the output hierarchy Mauro Carvalho Chehab
2023-03-14 11:41 ` Mauro Carvalho Chehab [this message]
2023-03-14 11:41 ` [igt-dev] [PATCH i-g-t 3/6] scripts/igt_doc.py: add support to generate testlists Mauro Carvalho Chehab
2023-03-14 11:41 ` [igt-dev] [PATCH i-g-t 4/6] scripts/igt_doc.py: prepare to place TestList class on a separate file Mauro Carvalho Chehab
2023-03-14 11:41 ` [igt-dev] [PATCH i-g-t 5/6] scripts/test_list.py: prepare to place " Mauro Carvalho Chehab
2023-03-14 11:41 ` [igt-dev] [PATCH i-g-t 6/6] scripts/igt_doc.py: re-introduce it by calling test_list.py Mauro Carvalho Chehab
2023-03-14 13:44 ` [igt-dev] ✓ Fi.CI.BAT: success for Do some improvements at igt_doc.py Patchwork
2023-03-15 17:40 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314114127.649447-3-mauro.chehab@linux.intel.com \
--to=mauro.chehab@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox