From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0379410E1CA for ; Mon, 20 Mar 2023 14:33:53 +0000 (UTC) From: Swati Sharma To: igt-dev@lists.freedesktop.org Date: Mon, 20 Mar 2023 20:06:22 +0530 Message-Id: <20230320143622.5166-1-swati2.sharma@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Luca Coelho Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: With this fix we are solving 2 issues. Firstly, the planes_scaling_combo() tests were leaving one scaler assigned after running sub-test with two consecutive planes because one scaler was getting reused in the next run. So with this fix scaler is not reused since we won't have any common plane. Secondly, when k == n_planes - 1, we were trying to access planes[n_planes], which led to array out of bounds error. So, with this fix, this issue is fixed too. v2: -fix condition if n_planes is not even (JP) Suggested-by: Luca Coelho Suggested-by: Juha-Pekka Heikkila Reported-by: Luca Coelho Signed-off-by: Swati Sharma --- tests/kms_plane_scaling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c index 3a6904afb..7feb45ca3 100644 --- a/tests/kms_plane_scaling.c +++ b/tests/kms_plane_scaling.c @@ -744,7 +744,7 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2, igt_assert(0); } - for (int k = 0; k < display->pipes[pipe].n_planes; k++) { + for (int k = 0; k < display->pipes[pipe].n_planes - 1; k += 2) { igt_plane_t *p1, *p2; p1 = &display->pipes[pipe].planes[k]; -- 2.25.1