From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id D050410E260 for ; Wed, 22 Mar 2023 00:05:30 +0000 (UTC) From: Umesh Nerlige Ramappa To: igt-dev@lists.freedesktop.org, Ashutosh Dixit , kamil.konieczny@linux.intel.com Date: Tue, 21 Mar 2023 17:05:10 -0700 Message-Id: <20230322000523.3310187-19-umesh.nerlige.ramappa@intel.com> In-Reply-To: <20230322000523.3310187-1-umesh.nerlige.ramappa@intel.com> References: <20230322000523.3310187-1-umesh.nerlige.ramappa@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v4 18/31] lib/i915/perf: Set missing metric unit for some counters List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lionel G Landwerlin Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Some counters do not have units specified, so use 'number' as the unit. v2: Drop " from commit description (Kamil) Signed-off-by: Umesh Nerlige Ramappa Acked-by: Ashutosh Dixit --- lib/i915/perf-configs/mdapi-xml-convert.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/i915/perf-configs/mdapi-xml-convert.py b/lib/i915/perf-configs/mdapi-xml-convert.py index 3b7d0663..eee12ad5 100755 --- a/lib/i915/perf-configs/mdapi-xml-convert.py +++ b/lib/i915/perf-configs/mdapi-xml-convert.py @@ -819,9 +819,14 @@ for arg in args.xml: # XXX Not sure why EU metrics tend to just be bundled under 'gpu' counter.set('mdapi_hw_unit_type', mdapi_counter.get('HWUnitType').lower()) + # Some counters do not have MetricUnits, treat them as number. + if mdapi_counter.get('MetricUnits') == None: + units = "number" + else: + units = mdapi_counter.get('MetricUnits').lower() + # There are counters representing cycle counts that have a semantic # type of 'duration' which doesn't seem to make sense... - units = mdapi_counter.get('MetricUnits').lower() if units == "cycles": semantic_type = "event" else: -- 2.36.1