From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 189B410E331 for ; Wed, 22 Mar 2023 00:05:33 +0000 (UTC) From: Umesh Nerlige Ramappa To: igt-dev@lists.freedesktop.org, Ashutosh Dixit , kamil.konieczny@linux.intel.com Date: Tue, 21 Mar 2023 17:05:17 -0700 Message-Id: <20230322000523.3310187-26-umesh.nerlige.ramappa@intel.com> In-Reply-To: <20230322000523.3310187-1-umesh.nerlige.ramappa@intel.com> References: <20230322000523.3310187-1-umesh.nerlige.ramappa@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v4 25/31] i915/perf: Make sanity check failures descriptive List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lionel G Landwerlin Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Make the asserts in the sanity check descriptive. Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Kamil Konieczny --- tests/i915/perf.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/i915/perf.c b/tests/i915/perf.c index 02d0f232..ce58a6b8 100644 --- a/tests/i915/perf.c +++ b/tests/i915/perf.c @@ -1017,7 +1017,9 @@ gen8_sanity_check_test_oa_reports(const uint32_t *oa_report0, continue; igt_debug("A40_%d: delta = %"PRIu64"\n", j, delta); - igt_assert(delta <= max_delta); + igt_assert_f(delta <= max_delta, + "A40_%d: delta = %"PRIu64", max_delta = %"PRIu64"\n", + j, delta, max_delta); } for (int j = 0; j < format.n_a64; j++) { @@ -1029,7 +1031,9 @@ gen8_sanity_check_test_oa_reports(const uint32_t *oa_report0, continue; igt_debug("A64_%d: delta = %"PRIu64"\n", format.first_a + j, delta); - igt_assert(delta <= max_delta); + igt_assert_f(delta <= max_delta, + "A64_%d: delta = %"PRIu64", max_delta = %"PRIu64"\n", + format.first_a + j, delta, max_delta); } for (int j = 0; j < format.n_a; j++) { @@ -1044,7 +1048,9 @@ gen8_sanity_check_test_oa_reports(const uint32_t *oa_report0, continue; igt_debug("A%d: delta = %"PRIu32"\n", a_id, delta); - igt_assert(delta <= max_delta); + igt_assert_f(delta <= max_delta, + "A%d: delta = %"PRIu32", max_delta = %"PRIu64"\n", + a_id, delta, max_delta); } /* The TestOa metric set defines all B counters to be a @@ -1106,7 +1112,9 @@ gen8_sanity_check_test_oa_reports(const uint32_t *oa_report0, igt_debug("C%d: delta = %"PRIu32", max_delta=%"PRIu64"\n", j, delta, max_delta); - igt_assert(delta <= max_delta); + igt_assert_f(delta <= max_delta, + "C%d: delta = %"PRIu32", max_delta = %"PRIu64"\n", + j, delta, max_delta); } } -- 2.36.1