From: Imre Deak <imre.deak@intel.com>
To: <igt-dev@lists.freedesktop.org>
Subject: [igt-dev] [PATCH i-g-t 1/2] tests/kms_dp_aux_dev: Factor out helper checking for sink detect errors
Date: Thu, 23 Mar 2023 18:18:07 +0200 [thread overview]
Message-ID: <20230323161808.1439499-1-imre.deak@intel.com> (raw)
For clarity, factor out a helper to check if the AUX transfer failed
due to not detecting the sink being connected.
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
tests/kms_dp_aux_dev.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
index 850ec8e26..86e111bf2 100644
--- a/tests/kms_dp_aux_dev.c
+++ b/tests/kms_dp_aux_dev.c
@@ -42,6 +42,19 @@ static bool is_mst_connector(int drm_fd, uint32_t connector_id)
NULL, NULL);
}
+static bool sink_detect_error(int drm_fd, uint32_t connector_id, int error_code)
+{
+ switch (error_code) {
+ case ETIMEDOUT:
+ return true;
+ case EIO:
+ return is_mst_connector(drm_fd, connector_id) ||
+ is_amdgpu_device(drm_fd);
+ default:
+ return false;
+ };
+}
+
static bool test(int drm_fd, uint32_t connector_id)
{
drmModeConnector *connector;
@@ -85,9 +98,7 @@ static bool test(int drm_fd, uint32_t connector_id)
ret > 0 ? "success" : strerror(errno));
igt_assert(ret == sizeof(buf) ||
- errno == ETIMEDOUT ||
- (errno == EIO && (is_mst_connector(drm_fd, connector_id) ||
- is_amdgpu_device(drm_fd))));
+ sink_detect_error(drm_fd, connector_id, errno));
close(fd);
--
2.37.1
next reply other threads:[~2023-03-23 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:18 Imre Deak [this message]
2023-03-23 16:18 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_dp_aux_dev: Treat ENXIO as a sink detect error Imre Deak
2023-03-23 23:11 ` Sripada, Radhakrishna
2023-03-23 17:12 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_dp_aux_dev: Factor out helper checking for sink detect errors Patchwork
2023-03-23 22:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-03-23 23:18 ` Imre Deak
2023-03-23 23:10 ` [igt-dev] [PATCH i-g-t 1/2] " Sripada, Radhakrishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323161808.1439499-1-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox